Make sampling heap profiler work for short living scripts.

Make sampling heap profiler work for short living scripts.

It might happen a script is gone during profiling. Handle that case.

Committed: https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7
Cr-Commit-Position: refs/heads/master@{#35052}

[alph, 2016-03-24 00:36:07]

alph@chromium.org changed reviewers:
+ ofrobots@google.com, yangguo@chromium.org

[alph, 2016-03-24 00:36:07]

ptal

[alph, 2016-03-24 00:36:15]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 00:36:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826953003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826953003/1

[commit-bot: I haz the power, 2016-03-24 00:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 00:57:52]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-03-24 05:20:26]

On 2016/03/24 00:57:52, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm.

[alph, 2016-03-24 06:04:29]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-03-24 06:04:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826953003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826953003/1

[commit-bot: I haz the power, 2016-03-24 06:06:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-24 06:06:58]

Description was changed from

==========
Make sampling heap profiler work for short living scripts.

It might happen a script is gone during profiling. Handle that case.
==========

to

==========
Make sampling heap profiler work for short living scripts.

It might happen a script is gone during profiling. Handle that case.

Committed: https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7
Cr-Commit-Position: refs/heads/master@{#35052}
==========

[commit-bot: I haz the power, 2016-03-24 06:06:59]

Patchset 1 (id:??) landed as
https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7
Cr-Commit-Position: refs/heads/master@{#35052}

[Michael Achenbach, 2016-03-24 09:18:25]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-03-24 09:18:25]

https://codereview.chromium.org/1826953003/diff/1/src/profiler/sampling-heap-...
File src/profiler/sampling-heap-profiler.cc (right):

https://codereview.chromium.org/1826953003/diff/1/src/profiler/sampling-heap-...
src/profiler/sampling-heap-profiler.cc:209: Name* name =
Name::cast(script->name());
Experimental code-coverage reports this block as not executed on x64. I see
three cases:
1) Is there really no test that exercises this, then please consider adding a v8
stand-alone test.
2) Is it executed in some other configuration? No action required.
3) It is executed in some test on x64? Then code coverage has a bug.