Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by alph Modified:
4 years, 9 months ago Reviewers:
ofrobots, Yang, Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMake sampling heap profiler work for short living scripts.
It might happen a script is gone during profiling. Handle that case.
Committed: https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7
Cr-Commit-Position: refs/heads/master@{#35052}
Patch Set 1 #
Total comments: 1
Created: 4 years, 9 months ago
Messages
Total messages: 14 (6 generated)
alph@chromium.org changed reviewers: + ofrobots@google.com, yangguo@chromium.org
ptal
The CQ bit was checked by alph@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826953003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/03/24 00:57:52, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. lgtm.
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826953003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make sampling heap profiler work for short living scripts. It might happen a script is gone during profiling. Handle that case. ========== to ========== Make sampling heap profiler work for short living scripts. It might happen a script is gone during profiling. Handle that case. Committed: https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7 Cr-Commit-Position: refs/heads/master@{#35052} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8b218d6464cf8c5eb63c23112f4d15933feba8c7 Cr-Commit-Position: refs/heads/master@{#35052}
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/1826953003/diff/1/src/profiler/sampling-heap-... File src/profiler/sampling-heap-profiler.cc (right): https://codereview.chromium.org/1826953003/diff/1/src/profiler/sampling-heap-... src/profiler/sampling-heap-profiler.cc:209: Name* name = Name::cast(script->name()); Experimental code-coverage reports this block as not executed on x64. I see three cases: 1) Is there really no test that exercises this, then please consider adding a v8 stand-alone test. 2) Is it executed in some other configuration? No action required. 3) It is executed in some test on x64? Then code coverage has a bug. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
