third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 1826853007: LayoutBox::mapContentsRectToVisibleRectInBorderBoxSpace()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1826853007: LayoutBox::mapContentsRectToVisibleRectInBorderBoxSpace() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi

Patch Set: Enable comparison, DO NOT CQ Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp ('k') | third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index b49d539afca42b34114e18eefccf3d55200781ed..0c75bbf499b44057a70a9d47e7cd6b3b86ac0889 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -491,15 +491,6 @@ bool LayoutView::mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* anc

if (document().printing())

return true;

- if (style()->isFlippedBlocksWritingMode()) {

chrishtr 2016/03/28 20:38:59 This is handled by LayoutBox somehow? Is this tes

Xianzhu 2016/03/28 21:12:08 Can a LayoutView have writing-mode?

chrishtr 2016/03/28 22:09:58 I think so. IIRC I added this code a month or so a

trchen 2016/03/28 22:22:42 Yes, LayoutView back-inherits the writing mode fro

- // We have to flip by hand since the view's logical height has not been determined. We

- // can use the viewport width and height.

- if (style()->isHorizontalWritingMode())

- rect.setY(viewHeight() - rect.maxY());

- else

- rect.setX(viewWidth() - rect.maxX());

- }

if (mode & IsFixed)

adjustOffsetForFixedPosition(rect);