Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1826833002: Reland of [counters] adding runtime call timers for GC (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
ulan, Camillo Bruni
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [counters] adding runtime call timers for GC (patchset #1 id:1 of https://codereview.chromium.org/1827563003/ ) Reason for revert: Reverting doesn't help here :/ Will disable the test. Original issue's description: > Revert of [counters] adding runtime call timers for GC (patchset #4 id:60001 of https://codereview.chromium.org/1825093002/ ) > > Reason for revert: > [Sheriff] ASAN bot is really badass today: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10844 > > Original issue's description: > > [counters] adding runtime call timers for GC > > > > Adding an additional timer for the GC to make the other runtime call counters > > more stable. > > > > BUG= > > > > Committed: https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af > > Cr-Commit-Position: refs/heads/master@{#35033} > > TBR=ulan@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/a1521c90d54bf4cdaaf4c6ae549d297d5779ac08 > Cr-Commit-Position: refs/heads/master@{#35034} TBR=ulan@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/25326bf8fde055356f6683c542215b639ba2e75a Cr-Commit-Position: refs/heads/master@{#35035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.h View 4 chunks +5 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Reland of [counters] adding runtime call timers for GC
4 years, 9 months ago (2016-03-23 16:02:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826833002/1
4 years, 9 months ago (2016-03-23 16:03:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 16:03:15 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 16:04:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25326bf8fde055356f6683c542215b639ba2e75a
Cr-Commit-Position: refs/heads/master@{#35035}

Powered by Google App Engine
This is Rietveld 408576698