Use a cache for inlining information (functions + token positions) to speed up function profile

Use a cache for inlining information (functions + token positions) to speed up function profile

- Further decreases profile build times for sra's reproduction (from 5-7 seconds down to 2-4 seconds).

Committed: https://github.com/dart-lang/sdk/commit/de5f641dfb58147f10603f1db48e6916b3c38cf4

[Cutch, 2016-03-23 21:31:09]

Description was changed from

==========
Use a cache for inlining information (functions + token positions) to speed up
function profile

BUG=
==========

to

==========
Use a cache for inlining information (functions + token positions) to speed up
function profile

- Further decreases profile build times for sra's reproduction (from 5-7 seconds
down to 2-4 seconds).
==========

[Cutch, 2016-03-23 21:31:09]

johnmccutchan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-03-23 21:55:41]

LGTMwC

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service.cc
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:1145: *inlined_token_positions = NULL;
Move this two lines inside the if below, or move them to the top of the
function.

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:1200: static const intptr_t kCacheSize = 128;
Do you have any performance data for cache size 16 and 64?

[Cutch, 2016-03-23 22:31:18]

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service.cc
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:1145: *inlined_token_positions = NULL;
On 2016/03/23 21:55:41, srdjan wrote:
> Move this two lines inside the if below, or move them to the top of the
> function.

Done.

https://codereview.chromium.org/1826753003/diff/1/runtime/vm/profiler_service...
runtime/vm/profiler_service.cc:1200: static const intptr_t kCacheSize = 128;
On 2016/03/23 21:55:40, srdjan wrote:
> Do you have any performance data for cache size 16 and 64?

I've tried 32 and 64 and settled on 128 because it had slightly better
performance. It's hard to tell the exact performance here because as the sample
buffer's contents changes the amount of work done by the profiler changes.

[Cutch, 2016-03-24 15:32:25]

Description was changed from

==========
Use a cache for inlining information (functions + token positions) to speed up
function profile

- Further decreases profile build times for sra's reproduction (from 5-7 seconds
down to 2-4 seconds).
==========

to

==========
Use a cache for inlining information (functions + token positions) to speed up
function profile

- Further decreases profile build times for sra's reproduction (from 5-7 seconds
down to 2-4 seconds).

Committed:
https://github.com/dart-lang/sdk/commit/de5f641dfb58147f10603f1db48e6916b3c38cf4
==========

[Cutch, 2016-03-24 15:32:27]

Committed patchset #3 (id:40001) manually as
de5f641dfb58147f10603f1db48e6916b3c38cf4 (presubmit successful).