(reland) build: Enable complex class copy ctor check by default.

(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
Committed: https://crrev.com/e9e46ca48d6ab8588fcce3d17351ebc0a6fb9f9e
Cr-Commit-Position: refs/heads/master@{#388071}

[vmpstr, 2016-03-23 00:05:38]

Please take a look. This depends on https://codereview.chromium.org/1825273002/

[dcheng, 2016-03-24 17:05:40]

lgtm

[vmpstr, 2016-03-28 18:25:13]

thakis@, could you take a look please?

[vmpstr, 2016-03-30 18:50:45]

On 2016/03/28 18:25:13, vmpstr wrote:
> thakis@, could you take a look please?

ping

[vmpstr, 2016-03-31 23:54:05]

vmpstr@chromium.org changed reviewers:
+ jochen@chromium.org

[vmpstr, 2016-03-31 23:54:06]

+jochen as well.

[jochen (gone - plz use gerrit), 2016-04-01 08:40:11]

lgtm

[vmpstr, 2016-04-01 20:25:39]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:26:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/40001

[commit-bot: I haz the power, 2016-04-01 20:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 20:36:04]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[vmpstr, 2016-04-12 18:27:24]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-04-12 18:27:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1826693002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 18:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/60001

[commit-bot: I haz the power, 2016-04-12 20:00:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-12 20:03:03]

Description was changed from

==========
build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
==========

to

==========
build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357

Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
Cr-Commit-Position: refs/heads/master@{#386787}
==========

[commit-bot: I haz the power, 2016-04-12 20:03:05]

Patchset 4 (id:??) landed as
https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
Cr-Commit-Position: refs/heads/master@{#386787}

[Nico, 2016-04-12 20:17:15]

since you didn't send a win_clang try bot, please watch
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang and
revert if necessary

[vmpstr, 2016-04-12 20:26:26]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1880243002/ by vmpstr@chromium.org.

The reason for reverting is: This breaks win_clang.

[vmpstr, 2016-04-14 18:23:15]

Description was changed from

==========
build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357

Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
Cr-Commit-Position: refs/heads/master@{#386787}
==========

to

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357

Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
Cr-Commit-Position: refs/heads/master@{#386787}
==========

[vmpstr, 2016-04-14 18:23:29]

Description was changed from

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357

Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
Cr-Commit-Position: refs/heads/master@{#386787}
==========

to

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
==========

[vmpstr, 2016-04-14 18:23:40]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 18:24:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/60001

[commit-bot: I haz the power, 2016-04-14 18:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 18:50:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2016-04-15 20:37:43]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-15 20:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/60001

[commit-bot: I haz the power, 2016-04-15 20:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 20:46:45]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[vmpstr, 2016-04-18 17:53:34]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2016-04-18 17:54:05]

The CQ bit was unchecked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-18 17:54:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/60001

[commit-bot: I haz the power, 2016-04-18 18:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:03:11]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[vmpstr, 2016-04-18 21:43:17]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-04-18 21:43:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826693002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826693002/60001

[commit-bot: I haz the power, 2016-04-18 23:17:15]

Description was changed from

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
==========

to

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
==========

[commit-bot: I haz the power, 2016-04-18 23:17:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-18 23:19:47]

Description was changed from

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357
==========

to

==========
(reland) build: Enable complex class copy ctor check by default.

This patch ensures that our FindBadConstructs plugin starts detecting
when a complex class requires an out of line copy constructor.

R=thakis@chromium.org, dcheng@chromium.org
BUG=436357

Committed: https://crrev.com/e9e46ca48d6ab8588fcce3d17351ebc0a6fb9f9e
Cr-Commit-Position: refs/heads/master@{#388071}
==========

[commit-bot: I haz the power, 2016-04-18 23:19:48]

Patchset 4 (id:??) landed as
https://crrev.com/e9e46ca48d6ab8588fcce3d17351ebc0a6fb9f9e
Cr-Commit-Position: refs/heads/master@{#388071}

[Nico, 2016-08-02 14:38:29]

Now that this has been on for a while, can we flip the default in the plugin and
then stop passing this flag?