Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5827)

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
index 3b6f34bd6abeb1f77a1a16f7856e42c5eefab3d4..3ede4356c65b0501f97be2098bff720850052ae1 100644
--- a/chrome/browser/resources/settings/search_page/search_page.html
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -1,10 +1,11 @@
+<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_page.html">
<link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">
<link rel="import" href="chrome://md-settings/settings_page/settings_animated_pages.html">
-<link rel="import" href="chrome://md-settings/settings_page/settings_subheader.html">
+<link rel="import" href="chrome://md-settings/settings_page/settings_subpage.html">
<link rel="import" href="chrome://md-settings/settings_shared_css.html">
<dom-module id="settings-search-page">
@@ -30,11 +31,11 @@
</paper-button>
</div>
</neon-animatable>
- <neon-animatable id="search-engines">
- <settings-subheader i18n-values="page-title:searchEnginesManage">
- </settings-subheader>
- <settings-search-engines-page></settings-search-engines-page>
- </neon-animatable>
+ <template is="dom-if" name="search-engines">
+ <settings-subpage page-title="[[i18n('searchEnginesManage')]]">
+ <settings-search-engines-page></settings-search-engines-page>
+ </settings-subpage>
+ </template>
</settings-animated-pages>
</template>
<script src="search_page.js"></script>

Powered by Google App Engine
This is Rietveld 408576698