chrome/browser/resources/settings/settings_page/settings_subpage.html - Issue 1826683002: MD Settings: Lazy-load sub-pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.html

Issue 1826683002: MD Settings: Lazy-load sub-pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WebAnimationsExterns

Patch Set: no-op Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/privacy_page/privacy_page.html ('K') | « chrome/browser/resources/settings/settings_page/settings_subheader.js ('k') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('j') | chrome/test/data/webui/settings/settings_page_browsertest.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

4 <link rel="import" href="chrome://md-settings/settings_shared_css.html">	6 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

5	7

6 <dom-module id="settings-subheader">	8 <dom-module id="settings-subpage">

7 <template>	9 <template>

8 <style include="settings-shared">	10 <style include="settings-shared">

9 :host {	11 :host {

10 display: block;	12 display: block;

11 margin: 8px 0 16px 0;	13 margin: 8px 0 16px 0;

12 }	14 }

13	15

14 :root {	16 :root {

15 --iron-icon-fill-color: var(--settings-nav-grey);	17 --iron-icon-fill-color: var(--settings-nav-grey);

16 }	18 }

17	19

18 paper-icon-button {	20 paper-icon-button {

19 /* The inner icon is 20px in size. paper-icon-button has 8px padding. */	21 /* The inner icon is 20px in size. paper-icon-button has 8px padding. */

20 height: 36px;	22 height: 36px;

21 /* Centers the ripple on the icon with appropriate margin on right. */	23 /* Centers the ripple on the icon with appropriate margin on right. */

22 margin: 0 12px 0 -8px;	24 margin: 0 12px 0 -8px;

23 width: 36px;	25 width: 36px;

24 }	26 }

25	27

26 h2 {	28 h2 {

27 color: var(--settings-nav-grey);	29 color: var(--settings-nav-grey);

28 font-size: 107.6923%; /* go to 14px from 13px */	30 font-size: 107.6923%; /* go to 14px from 13px */

29 }	31 }

30 </style>	32 </style>

31 <div class="settings-box first">	33 <div class="settings-box first">

32 <paper-icon-button icon="arrow-back" on-tap="onTapBack_">	34 <paper-icon-button icon="arrow-back" on-tap="onTapBack_">

33 </paper-icon-button>	35 </paper-icon-button>

34 <h2>[[pageTitle]]</h2>	36 <h2>[[pageTitle]]</h2>

35 </div>	37 </div>

	38 <content></content>

36 </template>	39 </template>

37 <script src="settings_subheader.js"></script>	40 <script src="settings_subpage.js"></script>

38 </dom-module>	41 </dom-module>

OLD	NEW