Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1826673002:
Add missing IPC struct member msaa_is_slow (Closed)
DescriptionAdd missing IPC struct member msaa_is_slow.
Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits.
Might explain some of the flakiness in GPU bots.
BUG=596730, 596475
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/9a7b8ea49fe9b5d8509a9a43275809ab759853a8
Cr-Commit-Position: refs/heads/master@{#382879}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Add missing IPC struct member msaa_is_slow BUG= ========== to ========== Add missing IPC struct member msaa_is_slow BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add missing IPC struct member msaa_is_slow BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + dcheng@chromium.org
Description was changed from ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730, 596475 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826673002/1
Message was sent while issue was closed.
Description was changed from ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730, 596475 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730, 596475 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730, 596475 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add missing IPC struct member msaa_is_slow. Missed this in previous CL: crrev.com/1781093002 - added this field to the capabilities, but not to the IPC struct traits. Might explain some of the flakiness in GPU bots. BUG=596730, 596475 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/9a7b8ea49fe9b5d8509a9a43275809ab759853a8 Cr-Commit-Position: refs/heads/master@{#382879} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9a7b8ea49fe9b5d8509a9a43275809ab759853a8 Cr-Commit-Position: refs/heads/master@{#382879} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
