Issue 1826663002: Add gn to DEPS file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1826663002: Add gn to DEPS file (Closed)

Created:
4 years, 9 months ago by dsinclair

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Add gn to DEPS file Pull the gn binary from google source. This is needed inorder to get git cl format to work correctly on mac. Added other platforms for completness. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0ac525005e15a6a67b04e8ab1553f4a1e18b0da7

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	DEPS	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

dsinclair

PTAL. I can't seem to run git cl format on my mac without this. Complains ...

4 years, 9 months ago (2016-03-22 23:03:56 UTC) #2

dsinclair

4 years, 9 months ago (2016-03-22 23:42:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0ac525005e15a6a67b04e8ab1553f4a1e18b0da7 (presubmit successful).