Draw infobar arrow border with width of 1px on any scale factor.

chrome/browser/ui/views/infobars/infobar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/infobars/infobar_view.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 84 matching lines @@
   if (ui::MaterialDesignController::IsModeMaterial()) {
     child_container_->SetPaintToLayer(true);
     child_container_->layer()->SetMasksToBounds(true);
     // Since MD doesn't use a gradient, we can set a solid bg color.
     child_container_->set_background(
         views::Background::CreateSolidBackground(infobars::InfoBar::GetTopColor(
             infobars::InfoBar::delegate()->GetInfoBarType())));
   }
 }
 
+const infobars::InfoBarContainer::Delegate* InfoBarView::container_delegate()
+    const {
+  const infobars::InfoBarContainer* infobar_container = container();
+  return infobar_container ? infobar_container->delegate() : NULL;
+}
+
 InfoBarView::~InfoBarView() {
   // We should have closed any open menus in PlatformSpecificHide(), then
   // subclasses' RunMenu() functions should have prevented opening any new ones
   // once we became unowned.
   DCHECK(!menu_runner_.get());
 }
 
 views::Label* InfoBarView::CreateLabel(const base::string16& text) const {
   views::Label* label = new views::Label(text, GetFontList());
   label->SizeToPreferredSize();
@@ skipping 52 matching lines @@
 
 // static
 void InfoBarView::AssignWidths(Labels* labels, int available_width) {
   std::sort(labels->begin(), labels->end(), SortLabelsByDecreasingWidth);
   AssignWidthsSorted(labels, available_width);
 }
 
 void InfoBarView::Layout() {
   // Calculate the fill and stroke paths.  We do this here, rather than in
   // PlatformSpecificRecalculateHeight(), because this is also reached when our
   // width is changed, which affects both paths.

[Peter Kasting, 2016/03/30 00:20:26]

Nit: Might want removal TODO here also

[Evan Stade, 2016/04/02 02:21:42]

Done.

   stroke_path_.rewind();
   fill_path_.rewind();
   const infobars::InfoBarContainer::Delegate* delegate = container_delegate();
   if (delegate) {
-    static_cast<InfoBarBackground*>(background())->set_separator_color(
-        delegate->GetInfoBarSeparatorColor());
     int arrow_x;
     SkScalar arrow_fill_height = SkIntToScalar(std::max(
         arrow_height() - InfoBarContainerDelegate::kSeparatorLineHeight, 0));
     SkScalar arrow_fill_half_width = SkIntToScalar(arrow_half_width());
     SkScalar separator_height =
         SkIntToScalar(InfoBarContainerDelegate::kSeparatorLineHeight);
     if (delegate->DrawInfoBarArrows(&arrow_x) && arrow_fill_height) {
       // Skia pixel centers are at the half-values, so the arrow is horizontally
       // centered at |arrow_x| + 0.5.  Vertically, the stroke path is the center
       // of the separator, while the fill path is a closed path that extends up
@@ skipping 126 matching lines @@
 
 int InfoBarView::EndX() const {
   return close_button_->x() - kBeforeCloseButtonSpacing;
 }
 
 int InfoBarView::OffsetY(views::View* view) const {
   return std::max((bar_target_height() - view->height()) / 2, 0) -
          (bar_target_height() - bar_height());
 }
 
-const infobars::InfoBarContainer::Delegate* InfoBarView::container_delegate()
-    const {
-  const infobars::InfoBarContainer* infobar_container = container();
-  return infobar_container ? infobar_container->delegate() : NULL;
-}
-
 void InfoBarView::RunMenuAt(ui::MenuModel* menu_model,
                             views::MenuButton* button,
                             views::MenuAnchorPosition anchor) {
   DCHECK(owner());  // We'd better not open any menus while we're closing.
   gfx::Point screen_point;
   views::View::ConvertPointToScreen(button, &screen_point);
   menu_runner_.reset(
       new views::MenuRunner(menu_model, views::MenuRunner::HAS_MNEMONICS));
   // Ignore the result since we don't need to handle a deleted menu specially.
   ignore_result(menu_runner_->RunMenuAt(GetWidget(),
@@ skipping 85 matching lines @@
 }
 
 bool InfoBarView::DoesIntersectRect(const View* target,
                                     const gfx::Rect& rect) const {
   DCHECK_EQ(this, target);
   // Only events that intersect the portion below the arrow are interesting.
   gfx::Rect non_arrow_bounds = GetLocalBounds();
   non_arrow_bounds.Inset(0, arrow_height(), 0, 0);
   return rect.Intersects(non_arrow_bounds);
 }