third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 1826623002: [DevTools] Move wrapCallFrames from InjectedScriptSource.js to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 1826623002: [DevTools] Move wrapCallFrames from InjectedScriptSource.js to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-no-scopes

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

index a462e873c2c6aa2d074a09b51a12e8be19a38073..84809ffd39108cd2c87cefb0ac9c42be2932b7c4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

@@ -83,8 +83,8 @@ public:

void stepOutOfFunction();

void clearStepping();

- bool setScriptSource(const String16& sourceID, const String16& newContent, bool preview, ErrorString*, Maybe<protocol::Debugger::SetScriptSourceError>*, v8::Global<v8::Object>* newCallFrames, Maybe<bool>* stackChanged);

- v8::Local<v8::Object> currentCallFrames();

+ bool setScriptSource(const String16& sourceID, const String16& newContent, bool preview, ErrorString*, Maybe<protocol::Debugger::SetScriptSourceError>*, OwnPtr<JavaScriptCallFrame>* newCallFrames, Maybe<bool>* stackChanged);

+ PassOwnPtr<JavaScriptCallFrame> currentCallFrames();

PassOwnPtr<JavaScriptCallFrame> callFrame(int index);

int frameCount();

@@ -151,7 +151,6 @@ private:

v8::Global<v8::FunctionTemplate> m_breakProgramCallbackTemplate;

v8::Global<v8::Object> m_debuggerScript;

v8::Global<v8::Context> m_debuggerContext;

- v8::Global<v8::FunctionTemplate> m_callFrameWrapperTemplate;

v8::Local<v8::Object> m_executionState;

v8::Local<v8::Context> m_pausedContext;

bool m_runningNestedMessageLoop;