Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 1826623002: [DevTools] Move wrapCallFrames from InjectedScriptSource.js to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-no-scopes
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
index f4f8eba399fa5617821b91e4cc5aba3e89f4e84f..46e6aab9553f9865b22245f2edc20aef271ad78a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
@@ -51,35 +51,17 @@ public:
int sourceID() const;
int line() const;
int column() const;
- String16 scriptName() const;
- String16 functionName() const;
- int functionLine() const;
- int functionColumn() const;
- v8::Local<v8::Value> scopeChain() const;
- v8::Local<v8::String> scopeType(int scopeIndex) const;
- v8::Local<v8::String> scopeName(int scopeIndex) const;
- v8::Local<v8::Value> scopeStartLocation(int scopeIndex) const;
- v8::Local<v8::Value> scopeEndLocation(int scopeIndex) const;
- v8::Local<v8::Value> thisObject() const;
- String16 stepInPositions() const;
bool isAtReturn() const;
- v8::Local<v8::Value> returnValue() const;
+ v8::Local<v8::Object> details() const;
v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);
v8::MaybeLocal<v8::Value> restart();
v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Value> variableName, v8::Local<v8::Value> newValue);
-
- // FIXME: store this template in per isolate data
- void setWrapperTemplate(v8::Local<v8::FunctionTemplate> wrapperTemplate, v8::Isolate* isolate) { m_wrapperTemplate.Reset(isolate, wrapperTemplate); }
- v8::Local<v8::FunctionTemplate> wrapperTemplate(v8::Isolate* isolate) { return v8::Local<v8::FunctionTemplate>::New(isolate, m_wrapperTemplate); }
-
private:
JavaScriptCallFrame(v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame);
int callV8FunctionReturnInt(const char* name) const;
- String16 callV8FunctionReturnString(const char* name) const;
- v8::Local<v8::Value> callScopeLocationFunction(const char* name, int scopeIndex) const;
v8::Isolate* m_isolate;
OwnPtr<JavaScriptCallFrame> m_caller;

Powered by Google App Engine
This is Rietveld 408576698