Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

Issue 1826623002: [DevTools] Move wrapCallFrames from InjectedScriptSource.js to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-no-scopes
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
diff --git a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js b/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
index 2816c3702a91ec38991e394481357226608cbf2f..dac8b542257b64e411ac266e98b85c72d1d74f56 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
+++ b/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
@@ -424,7 +424,7 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame)
if (!script)
return null;
- location = script.locationFromPosition(pos, true);
+ var location = script.locationFromPosition(pos, true);
dgozman 2016/03/23 00:12:35 What a fix! Nice!
return {
"lineNumber": location.line,
"columnNumber": location.column,
@@ -571,28 +571,6 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame)
return DebuggerScript._setScopeVariableValue(frameMirror, scopeNumber, variableName, newValue);
}
- function stepInPositions()
- {
- var stepInPositionsV8 = frameMirror.stepInPositions();
- var stepInPositionsProtocol;
- if (stepInPositionsV8) {
- stepInPositionsProtocol = [];
- var script = ensureFuncMirror().script();
- if (script) {
- var scriptId = String(script.id());
- for (var i = 0; i < stepInPositionsV8.length; i++) {
- var item = {
- scriptId: scriptId,
- lineNumber: stepInPositionsV8[i].position.line,
- columnNumber: stepInPositionsV8[i].position.column
- };
- stepInPositionsProtocol.push(item);
- }
- }
- }
- return JSON.stringify(stepInPositionsProtocol);
- }
-
return {
"sourceID": sourceID,
"line": line,
@@ -611,7 +589,6 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame)
"caller": callerFrame,
"restart": restart,
"setVariableValue": setVariableValue,
- "stepInPositions": stepInPositions,
"isAtReturn": isAtReturn,
"returnValue": returnValue
};

Powered by Google App Engine
This is Rietveld 408576698