[DevTools] Move wrapCallFrames from InjectedScriptSource.js to native

third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 400 matching lines @@
         scopeEndPositions[i] = scopeDetails.endPosition ? scopeDetails.endPosition() : 0;
         scopeFunctions[i] = scopeDetails.func ? scopeDetails.func() : null;
     }
 
     // Calculated lazily.
     var scopeChain;
     var funcMirror;
     var location;
     var scopeStartLocations;
     var scopeEndLocations;
+    var object;
 
     function createLocation(script, pos)
     {
         if (!script)
             return null;
 
-        location = script.locationFromPosition(pos, true);
+        var location = script.locationFromPosition(pos, true);
         return {
             "lineNumber": location.line,
             "columnNumber": location.column,
             "scriptId": String(script.id())
         }
     }
 
     function lazyScopeChain()
     {
         if (!scopeChain) {
@@ skipping 20 matching lines @@
             scopeTypes.length = scopeChain.length;
             scopeNames.length = scopeChain.length;
             scopeObjects = null; // Free for GC.
             scopeFunctions = null;
             scopeStartPositions = null;
             scopeEndPositions = null;
         }
         return scopeChain;
     }
 
-    function lazyScopeTypes()
+    function lazyObject()
     {
-        if (!scopeChain)
-            lazyScopeChain();
-        return scopeTypes;
-    }
-
-    function lazyScopeNames()
-    {
-        if (!scopeChain)
-            lazyScopeChain();
-        return scopeNames;
-    }
-
-    function lazyScopeStartLocations()
-    {
-        if (!scopeChain)
-            lazyScopeChain();
-
-        return scopeStartLocations;
-    }
-
-    function lazyScopeEndLocations()
-    {
-        if (!scopeChain)
-            lazyScopeChain();
-
-        return scopeEndLocations;
+        if (!object) {
+            var scopeObjects = lazyScopeChain();
+            var script = ensureFuncMirror().script();
+            var scopes = [];
+            for (var i = 0; i < scopeObjects.length; ++i) {
+                var scope = {
+                    "type": scopeTypes[i],
+                    "object": scopeObjects[i],
+                };
+                if (scopeNames[i])
+                    scope.name = scopeNames[i];
+                if (scopeStartLocations[i])
+                    scope.startLocation = scopeStartLocations[i];
+                if (scopeEndLocations[i])
+                    scope.endLocation = scopeEndLocations[i];
+                scopes.push(scope);
+            }
+            var functionLocation = ensureFuncMirror().sourceLocation();
+            object = {
+                "functionName": ensureFuncMirror().debugName(),
+                "location": {
+                    "lineNumber": line(),
+                    "columnNumber": column(),
+                    "scriptId": String(script.id())
+                },
+                "functionLocation": {
+                    "lineNumber": functionLocation.line,

[dgozman, 2016/03/23 18:46:31]

Previous code checked that there could be no functionLocation.

[kozy, 2016/03/23 19:15:10]

Done.

+                    "columnNumber": functionLocation.column,

[dgozman, 2016/03/23 18:46:31]

ditto

[kozy, 2016/03/23 19:15:10]

Done.

+                    "scriptId": String(script.id())
+                },
+                "this": thisObject,
+                "scopeChain": scopes
+            };
+            if (isAtReturn)
+                object.returnValue = returnValue;
+        }
+        return object;
     }
 
     function ensureFuncMirror()
     {
         if (!funcMirror) {
             funcMirror = MakeMirror(funcObject);
             if (!funcMirror.isFunction())
                 funcMirror = new UnresolvedFunctionMirror(funcObject);
         }
         return funcMirror;
@@ skipping 20 matching lines @@
     {
         return ensureLocation().column;
     }
 
     function sourceID()
     {
         var script = ensureFuncMirror().script();
         return script && script.id();
     }
 
-    function scriptName()
-    {
-        var script = ensureFuncMirror().script();
-        return script && script.name();
-    }
-
-    function functionName()
-    {
-        return ensureFuncMirror().debugName();
-    }
-
-    function functionLine()
-    {
-        var location = ensureFuncMirror().sourceLocation();
-        return location ? location.line : 0;
-    }
-
-    function functionColumn()
-    {
-        var location = ensureFuncMirror().sourceLocation();
-        return location ? location.column : 0;
-    }
-
     function evaluate(expression)
     {
         return frameMirror.evaluate(expression, false).value();
     }
 
     function restart()
     {
         return frameMirror.restart();
     }
 
     function setVariableValue(scopeNumber, variableName, newValue)
     {
         return DebuggerScript._setScopeVariableValue(frameMirror, scopeNumber, variableName, newValue);
     }
 
-    function stepInPositions()
-    {
-        var stepInPositionsV8 = frameMirror.stepInPositions();
-        var stepInPositionsProtocol;
-        if (stepInPositionsV8) {
-            stepInPositionsProtocol = [];
-            var script = ensureFuncMirror().script();
-            if (script) {
-                var scriptId = String(script.id());
-                for (var i = 0; i < stepInPositionsV8.length; i++) {
-                    var item = {
-                        scriptId: scriptId,
-                        lineNumber: stepInPositionsV8[i].position.line,
-                        columnNumber: stepInPositionsV8[i].position.column
-                    };
-                    stepInPositionsProtocol.push(item);
-                }
-            }
-        }
-        return JSON.stringify(stepInPositionsProtocol);
-    }
-
     return {
         "sourceID": sourceID,
         "line": line,
         "column": column,
-        "scriptName": scriptName,
-        "functionName": functionName,
-        "functionLine": functionLine,
-        "functionColumn": functionColumn,
         "thisObject": thisObject,
-        "scopeChain": lazyScopeChain,
-        "scopeType": lazyScopeTypes,
-        "scopeName": lazyScopeNames,
-        "scopeStartLocation": lazyScopeStartLocations,
-        "scopeEndLocation": lazyScopeEndLocations,
         "evaluate": evaluate,
         "caller": callerFrame,
         "restart": restart,
         "setVariableValue": setVariableValue,
-        "stepInPositions": stepInPositions,
         "isAtReturn": isAtReturn,
-        "returnValue": returnValue
+        "object": lazyObject

[dgozman, 2016/03/23 18:46:31]

details

[kozy, 2016/03/23 19:15:10]

Done.

     };
 }
 
 DebuggerScript._buildScopeObject = function(scopeType, scopeObject)
 {
     var result;
     switch (scopeType) {
     case ScopeType.Local:
     case ScopeType.Closure:
     case ScopeType.Catch:
@@ skipping 31 matching lines @@
         "parentPromise": eventData.parentPromise().value(),
         "status": eventData.status()
     };
 }
 
 // We never resolve Mirror by its handle so to avoid memory leaks caused by Mirrors in the cache we disable it.
 ToggleMirrorCache(false);
 
 return DebuggerScript;
 })();