Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1826613002:
Disable IOSurface clearing on OS X 10.9. (Closed)
DescriptionDisable IOSurface clearing on OS X 10.9.
Doing so triggers PDF rendering problems on some GPUs.
BUG=594343
TBR=avi@chromium.org
Committed: https://crrev.com/f38d1ce51f77c495dffb59d9c8d557881f3df448
Cr-Commit-Position: refs/heads/master@{#382739}
Patch Set 1 #Patch Set 2 : Disable tests on Mavericks. #Patch Set 3 : Fix compile errors. #
Messages
Total messages: 26 (12 generated)
erikchen@chromium.org changed reviewers: + ccameron@chromium.org, jbauman@chromium.org
ccameron, jbauman: Please review. This is going to be merged to M49 today.
lgtm
erikchen@chromium.org changed reviewers: + reveman@chromium.org - jbauman@chromium.org
oops. -jbauman, +reveman
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826613002/1
On 2016/03/22 21:30:44, erikchen wrote: > oops. -jbauman, +reveman Note: For security reasons, we may not be able to land or merge this.
lgtm do we have any idea why this is happening?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Disable IOSurface clearing on OS X 10.9. Doing so triggers PDF rendering problems on some GPUs. BUG=594343 ========== to ========== Disable IOSurface clearing on OS X 10.9. Doing so triggers PDF rendering problems on some GPUs. BUG=594343 TBR=avi@chromium.org ==========
erikchen@chromium.org changed reviewers: + avi@chromium.org
TBRing avi for ui/ OWNER, since this needs to be landed ASAP to be merged to M49.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1826613002/#ps20001 (title: "Disable tests on Mavericks.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826613002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/1826613002/#ps40001 (title: "Fix compile errors.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826613002/40001
lgtm OK
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disable IOSurface clearing on OS X 10.9. Doing so triggers PDF rendering problems on some GPUs. BUG=594343 TBR=avi@chromium.org ========== to ========== Disable IOSurface clearing on OS X 10.9. Doing so triggers PDF rendering problems on some GPUs. BUG=594343 TBR=avi@chromium.org Committed: https://crrev.com/f38d1ce51f77c495dffb59d9c8d557881f3df448 Cr-Commit-Position: refs/heads/master@{#382739} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f38d1ce51f77c495dffb59d9c8d557881f3df448 Cr-Commit-Position: refs/heads/master@{#382739} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
