Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1826603002:
Quick fix for broken JS notation (Closed)
DescriptionQuick fix for broken JS notation
Fix for issue: https://codereview.chromium.org/1811833002
TBR=sergeyu@chromium.org
BUG=
Committed: https://crrev.com/bd12932cbd6656a2de7ff0a639b01364dddac013
Cr-Commit-Position: refs/heads/master@{#382714}
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Quick fix for broken JS notation BUG= ========== to ========== Quick fix for broken JS notation TBR=sergeyu BUG= ==========
yuweih@chromium.org changed reviewers: + sergeyu@chromium.org
The CQ bit was checked by yuweih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826603002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Quick fix for broken JS notation TBR=sergeyu BUG= ========== to ========== Quick fix for broken JS notation TBR=sergeyu@chromium.org BUG= ==========
The CQ bit was checked by yuweih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826603002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
yuweih@chromium.org changed reviewers: + lambroslambrou@chromium.org
The CQ bit was checked by lambroslambrou@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826603002/1
Description was changed from ========== Quick fix for broken JS notation TBR=sergeyu@chromium.org BUG= ========== to ========== Quick fix for broken JS notation Fix for issue: https://codereview.chromium.org/1811833002 TBR=sergeyu@chromium.org BUG= ==========
Message was sent while issue was closed.
Description was changed from ========== Quick fix for broken JS notation Fix for issue: https://codereview.chromium.org/1811833002 TBR=sergeyu@chromium.org BUG= ========== to ========== Quick fix for broken JS notation Fix for issue: https://codereview.chromium.org/1811833002 TBR=sergeyu@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Quick fix for broken JS notation Fix for issue: https://codereview.chromium.org/1811833002 TBR=sergeyu@chromium.org BUG= ========== to ========== Quick fix for broken JS notation Fix for issue: https://codereview.chromium.org/1811833002 TBR=sergeyu@chromium.org BUG= Committed: https://crrev.com/bd12932cbd6656a2de7ff0a639b01364dddac013 Cr-Commit-Position: refs/heads/master@{#382714} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bd12932cbd6656a2de7ff0a639b01364dddac013 Cr-Commit-Position: refs/heads/master@{#382714}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1830483002/ by newt@chromium.org. The reason for reverting is: Caused compile failure on 64-bit Android bots. See crbug.com/597155. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
