Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 18266002: device: Gyp organization part 3 - final. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
miket_OOO, bryeung
CC:
chromium-reviews, Lei Zhang
Visibility:
Public.

Description

device: Gyp organization part 3 - final. Rename device.gyp to device_tests.gyp now that it only contain test targets. BUG=None R=bryeung@chromium.org, miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -70 lines) Patch
M build/all.gyp View 9 chunks +9 lines, -9 lines 0 comments Download
D device/device.gyp View 1 chunk +0 lines, -62 lines 0 comments Download
A + device/device_tests.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
The final part. Lei fyi, since you also reviewed the other patches. Thanks,
7 years, 5 months ago (2013-06-29 15:46:47 UTC) #1
miket_OOO
lgtm
7 years, 5 months ago (2013-07-01 16:39:50 UTC) #2
bryeung
lgtm
7 years, 5 months ago (2013-07-02 16:10:36 UTC) #3
tfarina
7 years, 5 months ago (2013-07-05 03:56:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r210256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698