Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: media/formats/mp4/box_definitions.cc

Issue 1826583003: MSE: Record counts of detected MSE audio, video and text tracks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Yet another attempt to fix that link failure. MEDIA_EXPORT should do it! Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/box_definitions.h ('k') | media/formats/mp4/fourccs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_definitions.cc
diff --git a/media/formats/mp4/box_definitions.cc b/media/formats/mp4/box_definitions.cc
index a95c78f9d163da7dbd052c74b3690b25cb46e7a3..ced31cc51dbc20dc3b552bc4bea80c259c74a1a6 100644
--- a/media/formats/mp4/box_definitions.cc
+++ b/media/formats/mp4/box_definitions.cc
@@ -461,6 +461,13 @@ bool HandlerReference::Parse(BoxReader* reader) {
type = kVideo;
} else if (hdlr_type == FOURCC_SOUN) {
type = kAudio;
+ } else if (hdlr_type == FOURCC_META || hdlr_type == FOURCC_SUBT ||
+ hdlr_type == FOURCC_TEXT || hdlr_type == FOURCC_SBTL) {
+ // For purposes of detection, we include 'sbtl' handler here. Note, though
+ // that ISO-14496-12 and its 2012 Amendment 2, and the spec for sourcing
+ // inband tracks all reference only 'text' or 'subt', and 14496-30
+ // references only 'subt'. Yet ffmpeg can encode subtitles as 'sbtl'.
+ type = kText;
} else {
type = kInvalid;
}
« no previous file with comments | « media/formats/mp4/box_definitions.h ('k') | media/formats/mp4/fourccs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698