Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1826533004: S390: Introduce a code stub version of Array.prototype.push (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Introduce a code stub version of Array.prototype.push Port 1134688cedecfdc35808d48fbdfeda49450cb618 Original commit message: This roughly doubles performance for generic Array.prototype.push. R=verwaest@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/2012e5643be3caff88d989ae9c19af292b37a7f5 Cr-Commit-Position: refs/heads/master@{#35030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 9 months ago (2016-03-23 13:18:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826533004/1
4 years, 9 months ago (2016-03-23 13:18:17 UTC) #3
JoranSiu
On 2016/03/23 13:18:17, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-23 13:19:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 13:41:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826533004/1
4 years, 9 months ago (2016-03-23 13:52:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 13:54:20 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 13:55:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2012e5643be3caff88d989ae9c19af292b37a7f5
Cr-Commit-Position: refs/heads/master@{#35030}

Powered by Google App Engine
This is Rietveld 408576698