Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 1826533003: Revert of [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index f54d777f31572dfbfe3fc1118b1c42ee47cb3dd5..58bd5efce0d831ca12c006fbb9a0b77277e8f14e 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -58,6 +58,9 @@
title = title.substring(ind + 3);
}
}
+ // Since the direction is switched to RTL, punctuation symbols appear on the
+ // left side, that is wrong. So, just remove trailing punctuation symbols.
+ title = title.replace(/[^A-Za-z0-9]+$/, '');
return title;
}
@@ -75,11 +78,13 @@
urlLink = item.ownerDocument.createElement('a');
urlLink.href = item.url;
urlLink.setAttribute('target', '_blank');
- urlLink.dir = 'ltr';
+ urlLink.textContent = item.shownUrl.split('').reverse().join('');
+
+ urlDiv.classList.add('left-elided-url');
} else {
urlLink = item.ownerDocument.createElement('span');
+ urlLink.textContent = item.shownUrl;
}
- urlLink.textContent = item.shownUrl;
urlLink.addEventListener('focus', function() {
item.handleFocus();
}.bind(item));
@@ -103,7 +108,6 @@
this.urlLink = createUrlLink(this, urlDiv);
urlDiv.appendChild(this.urlLink);
- this.urlDiv = urlDiv;
this.contentElement.appendChild(urlDiv);
// The stored username.
@@ -369,7 +373,6 @@
this.urlLink = createUrlLink(this, urlDiv);
urlDiv.appendChild(this.urlLink);
- this.urlDiv = urlDiv;
this.contentElement.appendChild(urlDiv);
},
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698