DescriptionRevert of [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (patchset #2 id:60001 of https://codereview.chromium.org/1817053002/ )
Reason for revert:
There is a bug in updateOriginsEliding_. The algorithm might fall to infinite loop.
CL also breaks "Closure Compilation Linux" (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). It complains on parseInt calls. parseInt should be called with 2 arguments (parsed string and base).
Original issue's description:
> [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords
>
> The previous implementation reversed the direction of text that causes bugs with screen readers, copying the origin.
>
> This CL introduces Javascript solution that dinamically adjusts the length of origin's string.
>
> BUG=595662, 595276
>
> Committed: https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb
> Cr-Commit-Position: refs/heads/master@{#382806}
TBR=estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595662, 595276
Committed: https://crrev.com/49fe82d1638da17aa71be0e6a7fb5f7c18deba70
Cr-Commit-Position: refs/heads/master@{#382814}
Patch Set 1 #
Messages
Total messages: 3 (2 generated)
|