Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1826533003: Revert of [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (Closed)

Created:
4 years, 9 months ago by kolos1
Modified:
4 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlistpasswordmanager_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords (patchset #2 id:60001 of https://codereview.chromium.org/1817053002/ ) Reason for revert: There is a bug in updateOriginsEliding_. The algorithm might fall to infinite loop. CL also breaks "Closure Compilation Linux" (https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/50842). It complains on parseInt calls. parseInt should be called with 2 arguments (parsed string and base). Original issue's description: > [Password Manager] Changes implementation of left elided origin on chrome://settings/passwords > > The previous implementation reversed the direction of text that causes bugs with screen readers, copying the origin. > > This CL introduces Javascript solution that dinamically adjusts the length of origin's string. > > BUG=595662, 595276 > > Committed: https://crrev.com/1f3fdc9a5caf59ff07ac0edc37123d17ee0640bb > Cr-Commit-Position: refs/heads/master@{#382806} TBR=estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595662, 595276 Committed: https://crrev.com/49fe82d1638da17aa71be0e6a7fb5f7c18deba70 Cr-Commit-Position: refs/heads/master@{#382814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M chrome/browser/resources/options/password_manager.js View 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.css View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/resources/options/password_manager_list.js View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
kolos1
4 years, 9 months ago (2016-03-23 09:34:41 UTC) #1
Created Revert of [Password Manager] Changes implementation of left elided
origin on chrome://settings/passwords

Powered by Google App Engine
This is Rietveld 408576698