Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1826483002: PPC: [stubs] Split ToNumberStub into reusable subparts. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Split ToNumberStub into reusable subparts. Port b7aa4c3ab35b3a28fee7fc49bf7aa1003d66959e Original commit message: Split ToNumberStub into the entry ToNumberStub, and two new stubs, StringToNumberStub and NonNumberToNumberStub, which can be used when we already know something about the input (i.e. in various branches of the code stubs, or in TurboFan graphs). Also introduce an appropriate StringToNumber simplified operator for TurboFan, that is pure and is lowered to an invocation of the newly added StringToNumberStub. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/69e8bb4357fd7592b6c2b50b70234b2586abb617 Cr-Commit-Position: refs/heads/master@{#34998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +32 lines, -17 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-22 15:27:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826483002/1
4 years, 9 months ago (2016-03-22 15:27:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 15:48:44 UTC) #5
john.yan
lgtm
4 years, 9 months ago (2016-03-22 16:47:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826483002/1
4 years, 9 months ago (2016-03-22 16:50:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:52:37 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:53:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69e8bb4357fd7592b6c2b50b70234b2586abb617
Cr-Commit-Position: refs/heads/master@{#34998}

Powered by Google App Engine
This is Rietveld 408576698