Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ui/views/window/dialog_client_view.h

Issue 1826433002: DialogClientView: Fix regression in Chrome Task Manager focusing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/window/dialog_client_view.cc » ('j') | ui/views/window/dialog_client_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/window/dialog_client_view.h
diff --git a/ui/views/window/dialog_client_view.h b/ui/views/window/dialog_client_view.h
index 60080b00c8ce0ce32b3c6b26d8fe8b9d01f9c248..d4657b782ea16602f192d1519288f58e963852a3 100644
--- a/ui/views/window/dialog_client_view.h
+++ b/ui/views/window/dialog_client_view.h
@@ -84,6 +84,14 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// Create a dialog button of the appropriate type.
LabelButton* CreateDialogButton(ui::DialogButton type);
+ // Adds |ok_button| as a child of this view at the appropriate index, to
+ // ensure correct focus order.
+ void AddOKButton(LabelButton* ok_button);
+
+ // Adds |cancel_button| as a child of this view at the appropriate index, to
+ // ensure correct focus order.
+ void AddCancelButton(LabelButton* cancel_button);
+
// Update |button|'s text and enabled state according to the delegate's state.
void UpdateButton(LabelButton* button, ui::DialogButton type);
@@ -96,10 +104,6 @@ class VIEWS_EXPORT DialogClientView : public ClientView,
// How much to inset the button row.
gfx::Insets button_row_insets_;
- // Sets up the focus chain for the child views. This is required since the
- // delegate may choose to add/remove views at any time.
- void SetupFocusChain();
-
// The dialog buttons.
LabelButton* ok_button_;
LabelButton* cancel_button_;
« no previous file with comments | « no previous file | ui/views/window/dialog_client_view.cc » ('j') | ui/views/window/dialog_client_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698