Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/animations/change-keyframes.html

Issue 1826423003: fix getComputedStyle positioned element values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Incorporated review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/animations/animation-properties-in-keyframe-are-ignored-expected.txt ('k') | third_party/WebKit/LayoutTests/animations/play-state.html » ('j') | third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/animations/change-keyframes.html
diff --git a/third_party/WebKit/LayoutTests/animations/change-keyframes.html b/third_party/WebKit/LayoutTests/animations/change-keyframes.html
index 97fda5a4cefb17df3182961a8f37ecc9c833d9d0..184aeb7156378b0fecb88552ecd1593226fd3cd0 100644
--- a/third_party/WebKit/LayoutTests/animations/change-keyframes.html
+++ b/third_party/WebKit/LayoutTests/animations/change-keyframes.html
@@ -43,7 +43,7 @@
// A forced style-recalc aborts the previous animation.
box.style.animationName = "none";
- assert_equals(getComputedStyle(box).left, 'auto', 'left');
+ assert_equals(getComputedStyle(box).left, '0px', 'left');
// Change keyframes.
var keyframes = findKeyframesRule("anim");
@@ -54,7 +54,7 @@
box.style.webkitAnimationName = "anim";
// The left property should reset to auto and top should be animating.
mstensho (USE GERRIT) 2016/04/04 09:13:26 No longer "auto", so you should update the comment
Mr. Kevin 2016/04/04 17:35:22 Done.
- assert_equals(getComputedStyle(box).left, 'auto', 'left');
+ assert_equals(getComputedStyle(box).left, '0px', 'left');
assert_equals(getComputedStyle(box).top, '100px', 'top');
}, "Check that changes to keyframe rules take effect");
</script>
« no previous file with comments | « third_party/WebKit/LayoutTests/animations/animation-properties-in-keyframe-are-ignored-expected.txt ('k') | third_party/WebKit/LayoutTests/animations/play-state.html » ('j') | third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/abspos-dialog-layout.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698