Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1826363002: Fix build warnings in third_party/android_data_chart. (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build warnings in third_party/android_data_chart. This fixes two warnings: - lint was warning about allocations during onLayout() in ChartView - javac was complaining about using the deprecated android.text.format.Time class. Turns out, that code was unused (since we no longer draw grid lines on the data usage chart), so I deleted it. Committed: https://crrev.com/0e96044e0ddda2b8d5d45e1d595fa76b9c9decd6 Cr-Commit-Position: refs/heads/master@{#383160}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated gn file #

Messages

Total messages: 12 (5 generated)
newt (away)
PTAL
4 years, 9 months ago (2016-03-24 20:30:25 UTC) #2
newt (away)
https://codereview.chromium.org/1826363002/diff/1/third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartGridView.java File third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartGridView.java (left): https://codereview.chromium.org/1826363002/diff/1/third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartGridView.java#oldcode94 third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartGridView.java:94: final float[] vertTicks = mVert.getTickPoints(); this is the only ...
4 years, 9 months ago (2016-03-24 20:31:54 UTC) #3
Ted C
lgtm
4 years, 9 months ago (2016-03-24 20:33:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826363002/1
4 years, 9 months ago (2016-03-24 20:33:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826363002/20001
4 years, 9 months ago (2016-03-24 20:59:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 22:08:52 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 22:10:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e96044e0ddda2b8d5d45e1d595fa76b9c9decd6
Cr-Commit-Position: refs/heads/master@{#383160}

Powered by Google App Engine
This is Rietveld 408576698