Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1826353002: Add a fallback mode for building summaries. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a fallback mode for building summaries. When summaries are built in fallback mode, the only information stored in the package bundle is (a) which libraries appear in the bundle, and (b) where the source files can be found on disk. This is enough information so that DDC will still be able to tell how libraries are grouped into build units, but otherwise summary functionality is disabled. This is intended to be availadle as a temporary workaround so that if a bug is found in the summary infrastructure, it won't prevent DDC compilation from working (it will just make it slower). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ea189bd6dcc66ebf4040576baa071c3887a3e55b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -63 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 18 chunks +62 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +17 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 3 chunks +77 lines, -54 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/in_summary_source_test.dart View 4 chunks +20 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-24 20:21:01 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-24 20:27:13 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-24 20:47:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea189bd6dcc66ebf4040576baa071c3887a3e55b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698