[TabManager] Protect tabs opened in background.

[TabManager] Protect tabs opened in background.

BUG=580690, 551995
Committed: https://crrev.com/0b7fc1ccb05b5fec8cbb4f4e6f79228f7aeb0d8e
Cr-Commit-Position: refs/heads/master@{#383727}

[Georges Khalil, 2016-03-24 19:41:08]

Description was changed from

==========
[TabManager] Protect tabs opened in background.

BUG=
==========

to

==========
[TabManager] Protect tabs opened in background.

BUG=580690,551995
==========

[Georges Khalil, 2016-03-24 19:41:08]

georgesak@chromium.org changed reviewers:
+ chrisha@chromium.org

[Georges Khalil, 2016-03-24 20:23:44]

Patchset #1 (id:1) has been deleted

[Georges Khalil, 2016-03-24 20:24:47]

chrisha@, PTAL.

[chrisha, 2016-03-29 12:48:40]

https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:297: const int kProtectionTime
= 5;
Maybe expose this constant from the tab_manager.h, so that it'll be updated
automatically across the unittests if ever changed?

[Georges Khalil, 2016-03-29 14:09:54]

chrisha@, PTAnL.

https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/t...
File chrome/browser/memory/tab_manager_browsertest.cc (right):

https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/t...
chrome/browser/memory/tab_manager_browsertest.cc:297: const int kProtectionTime
= 5;
On 2016/03/29 12:48:40, chrisha wrote:
> Maybe expose this constant from the tab_manager.h, so that it'll be updated
> automatically across the unittests if ever changed?

There's no constant in tab_manager.h as this value gets set through variations
for now.

If this changes, I will update it. Put a TODO as a reminder.

[chrisha, 2016-03-29 14:15:16]

Ah, okay. lgtm

[Georges Khalil, 2016-03-29 14:16:06]

The CQ bit was checked by georgesak@chromium.org

[commit-bot: I haz the power, 2016-03-29 14:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826333002/40001

[commit-bot: I haz the power, 2016-03-29 15:17:11]

Description was changed from

==========
[TabManager] Protect tabs opened in background.

BUG=580690,551995
==========

to

==========
[TabManager] Protect tabs opened in background.

BUG=580690,551995
==========

[commit-bot: I haz the power, 2016-03-29 15:17:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-29 15:19:14]

Description was changed from

==========
[TabManager] Protect tabs opened in background.

BUG=580690,551995
==========

to

==========
[TabManager] Protect tabs opened in background.

BUG=580690,551995

Committed: https://crrev.com/0b7fc1ccb05b5fec8cbb4f4e6f79228f7aeb0d8e
Cr-Commit-Position: refs/heads/master@{#383727}
==========

[commit-bot: I haz the power, 2016-03-29 15:19:14]

Patchset 2 (id:??) landed as
https://crrev.com/0b7fc1ccb05b5fec8cbb4f4e6f79228f7aeb0d8e
Cr-Commit-Position: refs/heads/master@{#383727}