Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1826333002: [TabManager] Protect tabs opened in background. (Closed)

Created:
4 years, 9 months ago by Georges Khalil
Modified:
4 years, 8 months ago
Reviewers:
chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TabManager] Protect tabs opened in background. BUG=580690, 551995 Committed: https://crrev.com/0b7fc1ccb05b5fec8cbb4f4e6f79228f7aeb0d8e Cr-Commit-Position: refs/heads/master@{#383727}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : chrisha@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -10 lines) Patch
M chrome/browser/memory/tab_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/memory/tab_manager_browsertest.cc View 1 3 chunks +36 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Georges Khalil
chrisha@, PTAL.
4 years, 9 months ago (2016-03-24 20:24:47 UTC) #4
chrisha
https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/tab_manager_browsertest.cc File chrome/browser/memory/tab_manager_browsertest.cc (right): https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/tab_manager_browsertest.cc#newcode297 chrome/browser/memory/tab_manager_browsertest.cc:297: const int kProtectionTime = 5; Maybe expose this constant ...
4 years, 8 months ago (2016-03-29 12:48:40 UTC) #5
Georges Khalil
chrisha@, PTAnL. https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/tab_manager_browsertest.cc File chrome/browser/memory/tab_manager_browsertest.cc (right): https://codereview.chromium.org/1826333002/diff/20001/chrome/browser/memory/tab_manager_browsertest.cc#newcode297 chrome/browser/memory/tab_manager_browsertest.cc:297: const int kProtectionTime = 5; On 2016/03/29 ...
4 years, 8 months ago (2016-03-29 14:09:54 UTC) #6
chrisha
Ah, okay. lgtm
4 years, 8 months ago (2016-03-29 14:15:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826333002/40001
4 years, 8 months ago (2016-03-29 14:16:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-03-29 15:17:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 15:19:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b7fc1ccb05b5fec8cbb4f4e6f79228f7aeb0d8e
Cr-Commit-Position: refs/heads/master@{#383727}

Powered by Google App Engine
This is Rietveld 408576698