third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html - Issue 1826323002: IntersectionObserver: use edge-inclusive geometry for intersections.

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html

Issue 1826323002: IntersectionObserver: use edge-inclusive geometry for intersections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-inclusive-geometry

Patch Set: refactor threshold index calculating code, fix test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/edge-inclusive-intersection-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target-expected.txt » ('j') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html

diff --git a/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html b/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html

index 4a5b435016c2a41bbe4515c576c9bed59f46ddc0..215f0058e5c7395ec8bdccdb6e3c53518ce7df8e 100644

--- a/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html

+++ b/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html

@@ -26,13 +26,13 @@

setTimeout(function() {

shouldBeEqualToNumber("entries.length", 1);

shouldBeEqualToNumber("entries[0].boundingClientRect.left", 8);

- shouldBeEqualToNumber("entries[0].boundingClientRect.right", 9);

+ shouldBeEqualToNumber("entries[0].boundingClientRect.right", 8);

shouldBeEqualToNumber("entries[0].boundingClientRect.top", 408);

- shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 409);

+ shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 408);

chrishtr 2016/03/24 23:33:11 Why did these change?

szager1 2016/03/25 08:02:38 Previously, IntersectionObserver would expand a ze

shouldBeEqualToNumber("entries[0].intersectionRect.left", 8);

- shouldBeEqualToNumber("entries[0].intersectionRect.right", 9);

+ shouldBeEqualToNumber("entries[0].intersectionRect.right", 8);

shouldBeEqualToNumber("entries[0].intersectionRect.top", 408);

- shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 409);

+ shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 408);

shouldBeEqualToNumber("entries[0].rootBounds.left", 0);

shouldBeEqualToNumber("entries[0].rootBounds.right", 785);

shouldBeEqualToNumber("entries[0].rootBounds.top", 0);

@@ -53,9 +53,9 @@

setTimeout(function() {

shouldBeEqualToNumber("entries.length", 2);

shouldBeEqualToNumber("entries[1].boundingClientRect.left", 8);

- shouldBeEqualToNumber("entries[1].boundingClientRect.right", 9);

+ shouldBeEqualToNumber("entries[1].boundingClientRect.right", 8);

shouldBeEqualToNumber("entries[1].boundingClientRect.top", 608);

- shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 609);

+ shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 608);

shouldBeEqualToNumber("entries[1].intersectionRect.left", 0);

shouldBeEqualToNumber("entries[1].intersectionRect.right", 0);

shouldBeEqualToNumber("entries[1].intersectionRect.top", 0);