Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1826323002: IntersectionObserver: use edge-inclusive geometry for intersections. (Closed)

Created:
4 years, 9 months ago by szager1
Modified:
4 years, 9 months ago
Reviewers:
chrishtr, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@intersection-observer-inclusive-geometry
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: use edge-inclusive geometry for intersections. Split this out from: https://codereview.chromium.org/1817693002/ BUG=540528 R=ojan@chromium.org,chrishtr@chromium.org Committed: https://crrev.com/1275d3aca4b5dab9bdaeac8255fd54fe58649182 Cr-Commit-Position: refs/heads/master@{#383371}

Patch Set 1 #

Total comments: 9

Patch Set 2 : refactor threshold index calculating code, fix test #

Total comments: 10

Patch Set 3 : tiny tweak #

Patch Set 4 : tweaks #

Total comments: 3

Patch Set 5 : Get rid of enum #

Patch Set 6 : refactor #

Messages

Total messages: 22 (2 generated)
szager1
4 years, 9 months ago (2016-03-24 19:36:47 UTC) #1
chrishtr
https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/LayoutTests/intersection-observer/edge.html File third_party/WebKit/LayoutTests/intersection-observer/edge.html (right): https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/LayoutTests/intersection-observer/edge.html#newcode1 third_party/WebKit/LayoutTests/intersection-observer/edge.html:1: <!DOCTYPE html> edge.html is not such a great name. ...
4 years, 9 months ago (2016-03-24 21:49:12 UTC) #2
szager1
https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/LayoutTests/intersection-observer/edge.html File third_party/WebKit/LayoutTests/intersection-observer/edge.html (right): https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/LayoutTests/intersection-observer/edge.html#newcode1 third_party/WebKit/LayoutTests/intersection-observer/edge.html:1: <!DOCTYPE html> On 2016/03/24 21:49:12, chrishtr wrote: > edge.html ...
4 years, 9 months ago (2016-03-24 23:14:08 UTC) #3
chrishtr
https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right): https://codereview.chromium.org/1826323002/diff/1/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#newcode181 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:181: if (m_shouldReportRootBounds) On 2016/03/24 at 23:14:08, szager1 wrote: > ...
4 years, 9 months ago (2016-03-24 23:30:20 UTC) #4
szager1
https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (left): https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#oldcode199 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:199: IntRect* rootBoundsPointer = m_shouldReportRootBounds ? &snappedRootBounds : nullptr; Here.
4 years, 9 months ago (2016-03-24 23:33:09 UTC) #5
chrishtr
https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html File third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html (right): https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html#newcode31 third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html:31: shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 408); Why did these change? https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ...
4 years, 9 months ago (2016-03-24 23:33:11 UTC) #6
chrishtr
https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (left): https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#oldcode199 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:199: IntRect* rootBoundsPointer = m_shouldReportRootBounds ? &snappedRootBounds : nullptr; On ...
4 years, 9 months ago (2016-03-24 23:35:30 UTC) #7
szager1
https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html File third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html (right): https://codereview.chromium.org/1826323002/diff/20001/third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html#newcode31 third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html:31: shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 408); On 2016/03/24 23:33:11, chrishtr wrote: > Why ...
4 years, 9 months ago (2016-03-25 08:02:39 UTC) #8
chrishtr
https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right): https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#newcode220 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:220: newThresholdIndex = observer().firstThresholdGreaterThan(newVisibleRatio); Oh I see. It is weird ...
4 years, 9 months ago (2016-03-25 14:54:47 UTC) #9
szager1
https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right): https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#newcode220 third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:220: newThresholdIndex = observer().firstThresholdGreaterThan(newVisibleRatio); On 2016/03/25 14:54:47, chrishtr wrote: > ...
4 years, 9 months ago (2016-03-25 17:03:11 UTC) #10
szager1
On 2016/03/25 17:03:11, szager1 wrote: > https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp > File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right): > > https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp#newcode220 > ...
4 years, 9 months ago (2016-03-25 17:04:40 UTC) #11
chrishtr
On 2016/03/25 at 17:04:40, szager wrote: > On 2016/03/25 17:03:11, szager1 wrote: > > https://codereview.chromium.org/1826323002/diff/60001/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ...
4 years, 9 months ago (2016-03-25 18:11:16 UTC) #12
szager1
On 2016/03/25 18:11:16, chrishtr wrote: > On 2016/03/25 at 17:04:40, szager wrote: > > On ...
4 years, 9 months ago (2016-03-25 18:20:06 UTC) #13
chrishtr
On 2016/03/25 at 18:20:06, szager wrote: > On 2016/03/25 18:11:16, chrishtr wrote: > > On ...
4 years, 9 months ago (2016-03-25 18:29:19 UTC) #14
szager1
On 2016/03/25 18:29:19, chrishtr wrote: > On 2016/03/25 at 18:20:06, szager wrote: > > On ...
4 years, 9 months ago (2016-03-25 18:50:54 UTC) #15
szager1
On 2016/03/25 18:29:19, chrishtr wrote: > > Ok. Per offline conversation, it would be clearer ...
4 years, 9 months ago (2016-03-25 18:51:28 UTC) #16
chrishtr
lgtm
4 years, 9 months ago (2016-03-25 20:12:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826323002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826323002/100001
4 years, 9 months ago (2016-03-25 20:12:51 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-25 21:42:07 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:45:43 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1275d3aca4b5dab9bdaeac8255fd54fe58649182
Cr-Commit-Position: refs/heads/master@{#383371}

Powered by Google App Engine
This is Rietveld 408576698