Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1826313003: [cronet] Add an isolate file for cronet_test_instrumentation_apk. (Closed)

Created:
4 years, 9 months ago by jbudorick
Modified:
4 years, 9 months ago
Reviewers:
agrieve, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cronet] Add an isolate file for cronet_test_instrumentation_apk. These files are used by QuicTestServer & PkpTest. They're currently handled as a special case in //build/android/pylib/instrumentation/setup.py that I'd like to get rid of. BUG= Committed: https://crrev.com/e18e7a6d2e1971e9b50b0ca3fe1fc9f17b264193 Cr-Commit-Position: refs/heads/master@{#383232}

Patch Set 1 #

Patch Set 2 : correct key locations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M build/config/android/rules.gni View 1 chunk +10 lines, -2 lines 0 comments Download
M components/cronet.gypi View 1 chunk +6 lines, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
A components/cronet/android/cronet_test_instrumentation_apk.isolate View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jbudorick
4 years, 9 months ago (2016-03-24 20:26:43 UTC) #2
agrieve
On 2016/03/24 20:26:43, jbudorick wrote: lgtm
4 years, 9 months ago (2016-03-24 21:11:29 UTC) #3
xunjieli
lgtm
4 years, 9 months ago (2016-03-24 21:13:12 UTC) #4
jbudorick
I'm going to land this, as it shouldn't affect any tests yet (famous last words) ...
4 years, 9 months ago (2016-03-25 01:49:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826313003/20001
4 years, 9 months ago (2016-03-25 01:49:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 03:08:00 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 03:09:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e18e7a6d2e1971e9b50b0ca3fe1fc9f17b264193
Cr-Commit-Position: refs/heads/master@{#383232}

Powered by Google App Engine
This is Rietveld 408576698