Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1826263002: Always create a BidiRun in SVGTextMetricsBuilder (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always create a BidiRun in SVGTextMetricsBuilder Create a BidiRun for the 'override' case too, to avoid a bunch of special cases. Since we always have a BidiRun now, null-checks can be removed, and code simplified a bit. (Hopefully even more in the future.) Also make "8-bit" (latin1) strings take this code-path. (This was handled by the SimpleShaper path previously.) BUG=594058 Committed: https://crrev.com/c53c160e1391842324a60c1391db9b6ff7ccf5bf Cr-Commit-Position: refs/heads/master@{#383224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 2 chunks +27 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-24 19:01:33 UTC) #2
pdr.
lgtm
4 years, 9 months ago (2016-03-25 01:58:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826263002/1
4 years, 9 months ago (2016-03-25 01:58:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 02:04:07 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 02:05:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c53c160e1391842324a60c1391db9b6ff7ccf5bf
Cr-Commit-Position: refs/heads/master@{#383224}

Powered by Google App Engine
This is Rietveld 408576698