Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1826233002:
Add rowBytesAsPixels and shiftPerPixel to SkPixmap (Closed)
|
Created:
4 years, 9 months ago by robertphillips Modified:
4 years, 9 months ago Reviewers:
reed1 CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd rowBytesAsPixels and shiftPerPixel to SkPixmap
This is intended to make it easier to manipulate SkBitmaps and SkPixmaps in a parallel manner (e.g., in https://codereview.chromium.org/1819393002/ (Switch SkMorphologyImageFilter over to new onFilterImage interface))
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1826233002
Committed: https://skia.googlesource.com/skia/+/3b5bea9d578b8f985ff62d50af3ee2c2de2299ed
Patch Set 1 #Patch Set 2 : Add cast #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap ========== to ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap This is intended to make it easier to manipulate SkBitmaps and SkPixmaps in a parallel manner (e.g., in https://codereview.chromium.org/1819393002/ (Switch SkMorphologyImageFilter over to new onFilterImage interface)) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + reed@google.com
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826233002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/1826233002/#ps20001 (title: "Add cast")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826233002/20001
Message was sent while issue was closed.
Description was changed from ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap This is intended to make it easier to manipulate SkBitmaps and SkPixmaps in a parallel manner (e.g., in https://codereview.chromium.org/1819393002/ (Switch SkMorphologyImageFilter over to new onFilterImage interface)) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add rowBytesAsPixels and shiftPerPixel to SkPixmap This is intended to make it easier to manipulate SkBitmaps and SkPixmaps in a parallel manner (e.g., in https://codereview.chromium.org/1819393002/ (Switch SkMorphologyImageFilter over to new onFilterImage interface)) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3b5bea9d578b8f985ff62d50af3ee2c2de2299ed ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3b5bea9d578b8f985ff62d50af3ee2c2de2299ed |
