Correctly handle child processes of sandboxed target processes.

Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests

Committed: https://crrev.com/5ce7612392ac2b13f0c1dda92467eb6b106538ac
Cr-Commit-Position: refs/heads/master@{#383221}

[Will Harris, 2016-03-24 22:28:56]

Description was changed from

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port
of to the calling process.

This was causing a mismatch in the target_process count since
it was not being incremented. This CL correctly increments
target_counter when these phantom processes are blocked.

Since it's not possible to know the process id of a a process
that has been blocked by the Job process limit, this CL adds
a second counter to track these untracked processes and verifies
when receving a JOB_OBJECT_MSG_EXIT_PROCESS or
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that it is either a fully
tracked process in broker->child_process_ids_ or that it is
an untracked child process of a target.

BUG=584753
TEST=sbox_integration_tests
==========

to

==========
123456789012345678901234567890123456789012345678901234567890123456789012
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

[Will Harris, 2016-03-24 22:28:56]

wfh@chromium.org changed reviewers:
+ jschuh@chromium.org

[Will Harris, 2016-03-24 22:29:13]

PTAL

[Will Harris, 2016-03-24 22:29:22]

Description was changed from

==========
123456789012345678901234567890123456789012345678901234567890123456789012
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

to

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

[jschuh, 2016-03-24 22:46:49]

Crazy. lgtm

[Will Harris, 2016-03-25 00:02:28]

On 2016/03/24 22:46:49, jschuh (very slow) wrote:
> Crazy. lgtm

Thanks for quick review.

verified this passes on the win10 swarming bot

https://chromium-swarm.appspot.com/user/task/2dc3de8c0719ba10

[Will Harris, 2016-03-25 00:02:31]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-03-25 00:02:31]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org
Link to the patchset: https://codereview.chromium.org/1826223004/#ps20001
(title: "remove unused test")

[commit-bot: I haz the power, 2016-03-25 00:02:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826223004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826223004/20001

[jschuh, 2016-03-25 00:03:26]

On 2016/03/25 00:02:28, Will Harris wrote:
> On 2016/03/24 22:46:49, jschuh (very slow) wrote:
> > Crazy. lgtm
> 
> Thanks for quick review.
> 
> verified this passes on the win10 swarming bot
> 
> https://chromium-swarm.appspot.com/user/task/2dc3de8c0719ba10

I know what you're trying to do here, but I refuse to acknowledge it until I see
evidence on the CQ and waterfall. :P

[Will Harris, 2016-03-25 00:05:09]

On 2016/03/25 00:03:26, jschuh (very slow) wrote:
> On 2016/03/25 00:02:28, Will Harris wrote:
> > On 2016/03/24 22:46:49, jschuh (very slow) wrote:
> > > Crazy. lgtm
> > 
> > Thanks for quick review.
> > 
> > verified this passes on the win10 swarming bot
> > 
> > https://chromium-swarm.appspot.com/user/task/2dc3de8c0719ba10
> 
> I know what you're trying to do here, but I refuse to acknowledge it until I
see
> evidence on the CQ and waterfall. :P

Soon™

[commit-bot: I haz the power, 2016-03-25 01:49:04]

Description was changed from

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

to

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

[commit-bot: I haz the power, 2016-03-25 01:49:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 01:50:18]

Description was changed from

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests
==========

to

==========
Correctly handle child processes of sandboxed target processes.

If the Job blocks child process creation then
JOB_OBJECT_MSG_ACTIVE_PROCESS_LIMIT followed by a
JOB_OBJECT_MSG_EXIT_PROCESS is sent to the job completion port of the
calling process.

This was causing a mismatch in the target_process count since it was not
being incremented. This CL correctly increments target_counter when
these phantom processes are blocked.

Since it's not possible to know the process id of a a process that has
been blocked by the Job process limit, this CL adds a second counter to
track these untracked processes and verifies when receving a
JOB_OBJECT_MSG_EXIT_PROCESS or JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS that
it is either a fully tracked process in broker->child_process_ids_ or
that it is an untracked child process of a target.

This also adds tests for the case when a child process and a child
process of a target crash, which tests the
JOB_OBJECT_MSG_ABNORMAL_EXIT_PROCESS path which was previously untested.

BUG=584753
TEST=sbox_integration_tests

Committed: https://crrev.com/5ce7612392ac2b13f0c1dda92467eb6b106538ac
Cr-Commit-Position: refs/heads/master@{#383221}
==========

[commit-bot: I haz the power, 2016-03-25 01:50:19]

Patchset 2 (id:??) landed as
https://crrev.com/5ce7612392ac2b13f0c1dda92467eb6b106538ac
Cr-Commit-Position: refs/heads/master@{#383221}