Issue 1826223002: Revert "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1826223002: Revert "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed." (Closed)

Created:
4 years, 9 months ago by Tom Sepez

Modified:
4 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Revert "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed." This reverts commit e432675850161570a8562f8c617da039f51f706d. Reson for revert - broke tests. TBR=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/129a60ec2d4d98ed953beaca629c99a52fb7e9b0

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -72 lines)			Patch
	M	fpdfsdk/jsapi/fxjs_v8.cpp	View		2 chunks	+7 lines, -6 lines	0 comments	Download
	M	fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp	View		2 chunks	+8 lines, -66 lines	0 comments	Download

Total messages: 3 (1 generated)

Tom Sepez

4 years, 9 months ago (2016-03-24 16:19:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
129a60ec2d4d98ed953beaca629c99a52fb7e9b0 (tree was closed).