Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1826203003: Revert of git cl: refactor Changelist codereview detection. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of git cl: refactor Changelist codereview detection. (patchset #4 id:60001 of https://codereview.chromium.org/1830923002/ ) Reason for revert: broke presubmit Original issue's description: > git cl: refactor Changelist codereview detection. > > BUG=579160 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299464 TBR=sergiyb@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579160, 597638 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -38 lines) Patch
M git_cl.py View 6 chunks +32 lines, -30 lines 0 comments Download
M tests/git_cl_test.py View 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tandrii(chromium)
Created Revert of git cl: refactor Changelist codereview detection.
4 years, 9 months ago (2016-03-24 17:32:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826203003/1
4 years, 9 months ago (2016-03-24 17:32:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299475
4 years, 9 months ago (2016-03-24 17:33:01 UTC) #5
Sergiy Byelozyorov
4 years, 9 months ago (2016-03-24 17:49:34 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698