Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1826193002: Add missing comma. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
etienneb
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add missing comma. We'd skip a test as the two strings would get joined, add the missing comma so all tests are run correctly. Found by: etienneb@ R=etienneb@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ad721813185598ea950c4f896c511bc4e5b41597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fpdftext/fpdf_text_int_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-24 15:25:49 UTC) #2
etienneb
lgtm
4 years, 9 months ago (2016-03-24 15:28:03 UTC) #3
dsinclair
Committed patchset #1 (id:1) manually as ad721813185598ea950c4f896c511bc4e5b41597 (presubmit successful).
4 years, 9 months ago (2016-03-24 15:30:09 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-24 16:15:53 UTC) #6
Message was sent while issue was closed.
Nice catch. thanks.

Powered by Google App Engine
This is Rietveld 408576698