Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826153003: Add subsection about Xcode license to Mac build instructions. (Closed)

Created:
4 years, 9 months ago by Thiemo Nagel
Modified:
4 years, 8 months ago
Reviewers:
cschuet (SLOW)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add subsection about Xcode license to Mac build instructions. BUG=None Committed: https://crrev.com/cad6316929d23996626ffd639a5f1677e1629465 Cr-Commit-Position: refs/heads/master@{#387571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M docs/mac_build_instructions.md View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Thiemo Nagel
Could you please take a look? Thank you! Thiemo
4 years, 9 months ago (2016-03-24 10:42:48 UTC) #2
Thiemo Nagel
Friendly ping.
4 years, 8 months ago (2016-04-15 10:21:02 UTC) #3
cschuet (SLOW)
On 2016/04/15 10:21:02, Thiemo Nagel (no reviews) wrote: > Friendly ping. lgtm
4 years, 8 months ago (2016-04-15 10:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826153003/1
4 years, 8 months ago (2016-04-15 10:24:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 11:02:49 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 11:04:33 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cad6316929d23996626ffd639a5f1677e1629465
Cr-Commit-Position: refs/heads/master@{#387571}

Powered by Google App Engine
This is Rietveld 408576698