Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826153002: Add supervised-user-internals and popular-sites-internals to chrome://about (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add supervised-user-internals and popular-sites-internals to chrome://about BUG=597293 Committed: https://crrev.com/a02317c0ca306333828f64520d691cc9ecdbaa87 Cr-Commit-Position: refs/heads/master@{#384278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Marc Treib
PTAL!
4 years, 9 months ago (2016-03-24 10:28:27 UTC) #2
Pam (message me for reviews)
On 2016/03/24 10:28:27, Marc Treib wrote: > PTAL! LGTM!
4 years, 8 months ago (2016-03-31 14:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826153002/1
4 years, 8 months ago (2016-03-31 14:23:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/166989)
4 years, 8 months ago (2016-03-31 14:26:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826153002/1
4 years, 8 months ago (2016-03-31 14:27:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 14:59:35 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 15:00:45 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a02317c0ca306333828f64520d691cc9ecdbaa87
Cr-Commit-Position: refs/heads/master@{#384278}

Powered by Google App Engine
This is Rietveld 408576698