Source/web/ContextMenuClientImpl.cpp - Issue 182613006: Remove media controls when not in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 182613006: Remove media controls when not in use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add shouldDisplayControls and fix overlay logic Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 8f16ffa83ec1e189f9df7a13b6ce4d83b9a96e69..52c59f9dcfa02f9b3f52c27e748b74b081b63cad 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -243,7 +243,7 @@ void ContextMenuClientImpl::showContextMenu(const WebCore::ContextMenu* defaultM

data.mediaFlags |= WebContextMenuData::MediaHasAudio;

if (mediaElement->hasVideo())

data.mediaFlags |= WebContextMenuData::MediaHasVideo;

- if (mediaElement->controls())

+ if (mediaElement->shouldDisplayControls())

data.mediaFlags |= WebContextMenuData::MediaControls;

} else if (r.innerNonSharedNode()->hasTagName(HTMLNames::objectTag)

|| r.innerNonSharedNode()->hasTagName(HTMLNames::embedTag)) {