Source/core/html/HTMLMediaElement.h - Issue 182613006: Remove media controls when not in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 182613006: Remove media controls when not in use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add shouldDisplayControls and fix overlay logic Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index c4df625a816d7280341172d594160b7dc9638965..5afd294b6853e4806858a861e142249a05d9a088 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -166,9 +166,13 @@ public:

void setMediaKeys(MediaKeys*, ExceptionState&);

DEFINE_ATTRIBUTE_EVENT_LISTENER(needkey);

- // controls

+ // This reflects the DOM attribute.

bool controls() const;

void setControls(bool);

+ // This version takes scripting and full screen mode into account.

+ bool shouldDisplayControls() const;

virtual double volume() const OVERRIDE FINAL;

virtual void setVolume(double, ExceptionState&) OVERRIDE FINAL;

virtual bool muted() const OVERRIDE FINAL;