Remove media controls when not in use.

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 392 matching lines @@
 {
     return true;
 }
 
 bool HTMLMediaElement::supportsFocus() const
 {
     if (ownerDocument()->isMediaDocument())
         return false;
 
     // If no controls specified, we should still be able to focus the element if it has tabIndex.
-    return controls() || HTMLElement::supportsFocus();
+    return shouldDisplayControls() || HTMLElement::supportsFocus();
 }
 
 bool HTMLMediaElement::isMouseFocusable() const
 {
     return false;
 }
 
 void HTMLMediaElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == srcAttr) {
@@ skipping 37 matching lines @@
     for (Element* child = ElementTraversal::firstWithin(*this); child; child = ElementTraversal::nextSibling(*child)) {
         if (child->hasTagName(trackTag)) {
             scheduleDelayedAction(LoadTextTrackResource);
             break;
         }
     }
 }
 
 bool HTMLMediaElement::rendererIsNeeded(const RenderStyle& style)
 {
-    return controls() ? HTMLElement::rendererIsNeeded(style) : false;
+    return shouldDisplayControls() ? HTMLElement::rendererIsNeeded(style) : false;
 }
 
 RenderObject* HTMLMediaElement::createRenderer(RenderStyle*)
 {
     return new RenderMedia(this);
 }
 
 Node::InsertionNotificationRequest HTMLMediaElement::insertedInto(ContainerNode* insertionPoint)
 {
     WTF_LOG(Media, "HTMLMediaElement::insertedInto");
@@ skipping 1808 matching lines @@
 }
 
 void HTMLMediaElement::setLoop(bool b)
 {
     WTF_LOG(Media, "HTMLMediaElement::setLoop(%s)", boolString(b));
     setBooleanAttribute(loopAttr, b);
 }
 
 bool HTMLMediaElement::controls() const
 {
+    return fastHasAttribute(controlsAttr);
+}
+
+bool HTMLMediaElement::shouldDisplayControls() const
+{
     LocalFrame* frame = document().frame();
 
     // always show controls when scripting is disabled
     if (frame && !frame->script().canExecuteScripts(NotAboutToExecuteScript))
         return true;
 
-    // Always show controls when in full screen mode.
-    if (isFullscreen())
+    // Show controls when in full screen mode unless there is an overlay player.
+    if (isFullscreen() && !RuntimeEnabledFeatures::overlayFullscreenVideoEnabled())

[qinmin, 2014/02/28 17:12:45]

overlayFullscreenVideoEnabled is enabled by default for android, the actual flag
in chromium is enable-overlay-fullscreen-video-subtitle, which is not passed to
blink.

         return true;
 
-    return fastHasAttribute(controlsAttr);
+    return controls();
 }
 
 void HTMLMediaElement::setControls(bool b)
 {
     WTF_LOG(Media, "HTMLMediaElement::setControls(%s)", boolString(b));
     setBooleanAttribute(controlsAttr, b);
 }
 
 double HTMLMediaElement::volume() const
 {
@@ skipping 1258 matching lines @@
     if (!mediaControls)
         return false;
 
     mediaControls->setMediaController(m_mediaController ? m_mediaController.get() : static_cast<MediaControllerInterface*>(this));
     mediaControls->reset();
     if (isFullscreen())
         mediaControls->enteredFullscreen();
 
     ensureUserAgentShadowRoot().appendChild(mediaControls);
 
-    if (!controls() || !inDocument())
+    if (!shouldDisplayControls() || !inDocument())
         mediaControls->hide();
 
     return true;
 }
 
 void HTMLMediaElement::configureMediaControls()
 {
-    if (!controls() || !inDocument()) {
-        if (hasMediaControls())
-            mediaControls()->hide();
+    if (!shouldDisplayControls() || !inDocument()) {
+        if (hasMediaControls()) {
+            if (!shouldDisplayControls())
+                userAgentShadowRoot()->removeChild(mediaControls());
+            else
+                mediaControls()->hide();
+        }
         return;
     }
 
     if (!hasMediaControls() && !createMediaControls())
         return;
 
     mediaControls()->show();
 }
 
 void HTMLMediaElement::configureTextTrackDisplay(VisibilityChangeAssumption assumption)
@@ skipping 288 matching lines @@
 {
     m_mediaSource->setWebMediaSourceAndOpen(adoptPtr(webMediaSource));
 }
 
 bool HTMLMediaElement::isInteractiveContent() const
 {
     return fastHasAttribute(controlsAttr);
 }
 
 }