Remove media controls when not in use.

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 2285 matching lines @@
 }
 
 bool HTMLMediaElement::controls() const
 {
     LocalFrame* frame = document().frame();
 
     // always show controls when scripting is disabled
     if (frame && !frame->script().canExecuteScripts(NotAboutToExecuteScript))
         return true;
 
-    // Always show controls when in full screen mode.
+#if !OS(ANDROID)
+    // Always show controls when in full screen mode, except on Android which

[qinmin, 2014/02/27 18:07:40]

This is a wrong assumption

+    // has a native UI overlay player.
     if (isFullscreen())

[acolwell GONE FROM CHROMIUM, 2014/02/27 18:35:23]

This and the "script disabled" code above seems misplaced. This code causes the
JS object attribute to differ from the content attribute, which violates the
HTML5 spec
(http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#dom-medi...)

It seems like this logic should be in a shouldDisplayControls() function instead
of controls().

         return true;
+#endif
 
     return fastHasAttribute(controlsAttr);
 }
 
 void HTMLMediaElement::setControls(bool b)
 {
     WTF_LOG(Media, "HTMLMediaElement::setControls(%s)", boolString(b));
     setBooleanAttribute(controlsAttr, b);
 }
 
@@ skipping 1269 matching lines @@
 
     if (!controls() || !inDocument())
         mediaControls->hide();
 
     return true;
 }
 
 void HTMLMediaElement::configureMediaControls()
 {
     if (!controls() || !inDocument()) {
-        if (hasMediaControls())
-            mediaControls()->hide();
+        if (hasMediaControls()) {
+            if (!controls())
+                ensureUserAgentShadowRoot().removeChild(mediaControls());

[acolwell GONE FROM CHROMIUM, 2014/02/27 18:35:23]

Why is this needed? What are you trying to solve with this?

+            else
+                mediaControls()->hide();
+        }
         return;
     }
 
     if (!hasMediaControls() && !createMediaControls())
         return;
 
     mediaControls()->show();
 }
 
 void HTMLMediaElement::configureTextTrackDisplay(VisibilityChangeAssumption assumption)
@@ skipping 288 matching lines @@
 {
     m_mediaSource->setWebMediaSourceAndOpen(adoptPtr(webMediaSource));
 }
 
 bool HTMLMediaElement::isInteractiveContent() const
 {
     return fastHasAttribute(controlsAttr);
 }
 
 }