Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 182613003: Promise.all and Promise.race reject non-array parameter. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Promise.all and Promise.race should reject non-array parameter. Promise.all and Promise.race should reject the returned Promise if an invalid parameter is given. Since they don't support iterable now, they should reject the Promise if a non-array parameter is given. BUG=347453 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19754

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/promise.js View 2 chunks +8 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/promises.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
6 years, 9 months ago (2014-02-27 08:32:08 UTC) #1
rossberg
https://codereview.chromium.org/182613003/diff/1/test/mjsunit/harmony/promises.js File test/mjsunit/harmony/promises.js (right): https://codereview.chromium.org/182613003/diff/1/test/mjsunit/harmony/promises.js#newcode562 test/mjsunit/harmony/promises.js:562: Promise.all({get length() { throw 666 }}).chain( Nit: I would ...
6 years, 9 months ago (2014-02-27 08:45:27 UTC) #2
yhirano
https://codereview.chromium.org/182613003/diff/1/test/mjsunit/harmony/promises.js File test/mjsunit/harmony/promises.js (right): https://codereview.chromium.org/182613003/diff/1/test/mjsunit/harmony/promises.js#newcode562 test/mjsunit/harmony/promises.js:562: Promise.all({get length() { throw 666 }}).chain( On 2014/02/27 08:45:28, ...
6 years, 9 months ago (2014-02-27 08:54:51 UTC) #3
rossberg
lgtm
6 years, 9 months ago (2014-02-27 09:30:28 UTC) #4
rossberg
6 years, 9 months ago (2014-03-10 12:01:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698