CacheStorage: Pass url::Origin rather than GURL over IPC

CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482
Committed: https://crrev.com/9f1be5affd71497458f19e45b73d3a45b9f28e73
Cr-Commit-Position: refs/heads/master@{#384743}

[Mike West, 2016-03-24 14:29:23]

LGTM, assuming that this does the right thing given a unqiue origin. `Serialize`
will return "null". Will that explode?

https://codereview.chromium.org/1826103002/diff/1/content/browser/cache_stora...
File content/browser/cache_storage/cache_storage_dispatcher_host.cc (right):

https://codereview.chromium.org/1826103002/diff/1/content/browser/cache_stora...
content/browser/cache_storage/cache_storage_dispatcher_host.cc:57: return
IsOriginSecure(GURL(origin.Serialize()));
Hrm. We should make this take an origin at some point. :/

[jsbell, 2016-03-24 16:31:57]

In theory, none of these storage types should be permitted for unique origins. I
should add DCHECKs/BadMessage as appropriate, though.

https://codereview.chromium.org/1826103002/diff/1/content/browser/cache_stora...
File content/browser/cache_storage/cache_storage_dispatcher_host.cc (right):

https://codereview.chromium.org/1826103002/diff/1/content/browser/cache_stora...
content/browser/cache_storage/cache_storage_dispatcher_host.cc:57: return
IsOriginSecure(GURL(origin.Serialize()));
On 2016/03/24 14:29:23, Mike West wrote:
> Hrm. We should make this take an origin at some point. :/

Yep. I'll tackle that in an upcoming CL.

[jsbell, 2016-03-30 23:27:48]

jsbell@chromium.org changed reviewers:
+ jkarlin@chromium.org, michaeln@chromium.org

[jsbell, 2016-03-30 23:27:48]

michaeln@, jkarlin@ - can you take a look?

Note that I do plan a follow-up to swap GURL -> url::Origin in the guts of the
content/browser/cache_storage code (and Quota and...), but not written yet.

[jkarlin, 2016-03-31 11:31:49]

lgtm with nits. Please update the comment to say browser/cache_storage instead
of browser/indexed_db

https://codereview.chromium.org/1826103002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_dispatcher_host.cc (right):

https://codereview.chromium.org/1826103002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_dispatcher_host.cc:25: #include
"url/gurl.h"
#include "url/origin.h"

[jsbell, 2016-03-31 16:28:32]

Description was changed from

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/indexed_db still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

R=mkwst@chromium.org
BUG=591482
==========

to

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

R=mkwst@chromium.org
BUG=591482
==========

[jsbell, 2016-03-31 16:28:41]

Description was changed from

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

R=mkwst@chromium.org
BUG=591482
==========

to

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482
==========

[jsbell, 2016-04-01 19:04:05]

jsbell@chromium.org changed reviewers:
+ jam@chromium.org

[jsbell, 2016-04-01 19:04:06]

jam@ - can you OWNERS review the
content/renderer/renderer_blink_platform_impl.cc change?

https://codereview.chromium.org/1826103002/diff/20001/content/browser/cache_s...
File content/browser/cache_storage/cache_storage_dispatcher_host.cc (right):

https://codereview.chromium.org/1826103002/diff/20001/content/browser/cache_s...
content/browser/cache_storage/cache_storage_dispatcher_host.cc:25: #include
"url/gurl.h"
On 2016/03/31 11:31:49, jkarlin wrote:
> #include "url/origin.h"

Done.

[jam, 2016-04-01 22:51:03]

On 2016/04/01 19:04:06, jsbell wrote:
> jam@ - can you OWNERS review the
> content/renderer/renderer_blink_platform_impl.cc change?
lgtm

[jsbell, 2016-04-01 22:51:21]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-04-01 22:51:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1826103002/#ps40001
(title: "Add missing include")

[commit-bot: I haz the power, 2016-04-01 22:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826103002/40001

[commit-bot: I haz the power, 2016-04-02 00:06:35]

Description was changed from

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482
==========

to

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482
==========

[commit-bot: I haz the power, 2016-04-02 00:06:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-02 00:08:28]

Description was changed from

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482
==========

to

==========
CacheStorage: Pass url::Origin rather than GURL over IPC

Eliminate some WebSecurityOrigin -> string -> GURL conversions prior
to IPC. The CacheStorage back-end in content/browser/cache_storage still
uses GURL internally, so there's more cleanup to be done in
follow-ups.

BUG=591482

Committed: https://crrev.com/9f1be5affd71497458f19e45b73d3a45b9f28e73
Cr-Commit-Position: refs/heads/master@{#384743}
==========

[commit-bot: I haz the power, 2016-04-02 00:08:29]

Patchset 3 (id:??) landed as
https://crrev.com/9f1be5affd71497458f19e45b73d3a45b9f28e73
Cr-Commit-Position: refs/heads/master@{#384743}