Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 18261009: Have repeats understand "time" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes from dennisjeffrey Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 12f227f7879cfe6fec25cb0927225efbfe8e54de..490f2c8ac42b5b13fd60cd9e93ac497082692279 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -107,13 +107,15 @@ class PageTest(object):
"""Override to customize if the test can be ran for the given page."""
return True
- def WillRunPageSet(self, tab):
- """Override to do operations before the page set is navigated."""
+ def WillRunTest(self, tab):
+ """Override to do operations before the page set(s) are navigated."""
pass
- def DidRunPageSet(self, tab, results):
- """Override to do operations after page set is completed, but before browser
- is torn down."""
+ def DidRunTest(self, tab, results):
+ """Override to do operations after all page set(s) are completed.
+
+ This will occur before the browser is torn down.
+ """
pass
def DidStartHTTPServer(self, tab):

Powered by Google App Engine
This is Rietveld 408576698