Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 18261009: Have repeats understand "time" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding regex for arg parsing and suggested changes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 12f227f7879cfe6fec25cb0927225efbfe8e54de..70e3a55d125ab89c58097ee82700e923c99ca8af 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -107,13 +107,14 @@ class PageTest(object):
"""Override to customize if the test can be ran for the given page."""
return True
- def WillRunPageSet(self, tab):
- """Override to do operations before the page set is navigated."""
+ def WillRunTest(self, tab):
+ """Override to do operations before the page set(s) are navigated."""
pass
- def DidRunPageSet(self, tab, results):
- """Override to do operations after page set is completed, but before browser
- is torn down."""
+ def DidRunTest(self, tab, results):
+ """Override to do operations after all page set(s) are completed, but before
+
+ browser is torn down."""
dtu 2013/07/11 17:28:38 Sorry, this isn't quite what Dennis meant. The fir
edmundyan 2013/07/11 18:55:01 Got it now, thanks.
pass
def DidStartHTTPServer(self, tab):

Powered by Google App Engine
This is Rietveld 408576698