Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18261007: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed)

Created:
7 years, 5 months ago by scherkus (not reviewing)
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Migrate webkit/renderer/media/ to content/renderer/media/. This moves everything except the crypto bits. BUG=251306 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210912

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix android #

Patch Set 4 : rebase and fix win #

Patch Set 5 : fix win64 AGAIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -8185 lines) Patch
M content/content_renderer.gypi View 1 6 chunks +38 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/media/active_loader.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/active_loader.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/android/media_info_loader.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/media_info_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 5 chunks +8 lines, -12 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
A + content/renderer/media/audio_decoder.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + content/renderer/media/audio_decoder.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A + content/renderer/media/buffered_data_source.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + content/renderer/media/buffered_data_source.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/buffered_data_source_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/media/buffered_resource_loader.h View 1 2 3 3 chunks +9 lines, -7 lines 0 comments Download
A + content/renderer/media/buffered_resource_loader.cc View 5 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/media/buffered_resource_loader_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/cache_util.h View 2 chunks +8 lines, -6 lines 0 comments Download
A + content/renderer/media/cache_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/cache_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/media_stream_audio_renderer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/media_stream_audio_renderer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/media/media_stream_client.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 4 chunks +9 lines, -12 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A + content/renderer/media/preload.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/rtc_video_renderer.h View 4 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/media/test_response_generator.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/test_response_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/texttrack_impl.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/texttrack_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/media/video_frame_provider.h View 3 chunks +9 lines, -6 lines 0 comments Download
A + content/renderer/media/video_frame_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webaudiosourceprovider_impl.h View 1 2 3 4 4 chunks +9 lines, -8 lines 0 comments Download
A + content/renderer/media/webaudiosourceprovider_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webaudiosourceprovider_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webinbandtexttrack_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/webinbandtexttrack_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webmediaplayer_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/webmediaplayer_impl.h View 4 chunks +6 lines, -7 lines 0 comments Download
A + content/renderer/media/webmediaplayer_impl.cc View 1 8 chunks +16 lines, -13 lines 0 comments Download
A + content/renderer/media/webmediaplayer_ms.h View 4 chunks +8 lines, -7 lines 0 comments Download
A + content/renderer/media/webmediaplayer_ms.cc View 4 chunks +8 lines, -8 lines 0 comments Download
A + content/renderer/media/webmediaplayer_params.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/media/webmediaplayer_params.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webmediaplayer_util.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/webmediaplayer_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/media/webmediasourceclient_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/webmediasourceclient_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.h View 5 chunks +6 lines, -6 lines 0 comments Download
A + content/renderer/media/websourcebuffer_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/renderer/media/websourcebuffer_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 8 chunks +6 lines, -10 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 6 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M content/test/test_media_stream_client.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/test/test_media_stream_client.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M content/test/test_video_frame_provider.h View 3 chunks +3 lines, -3 lines 0 comments Download
D webkit/renderer/media/active_loader.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/renderer/media/active_loader.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/renderer/media/audio_decoder.h View 1 chunk +0 lines, -20 lines 0 comments Download
D webkit/renderer/media/audio_decoder.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D webkit/renderer/media/buffered_data_source.h View 1 chunk +0 lines, -220 lines 0 comments Download
D webkit/renderer/media/buffered_data_source.cc View 1 chunk +0 lines, -538 lines 0 comments Download
D webkit/renderer/media/buffered_data_source_unittest.cc View 1 chunk +0 lines, -657 lines 0 comments Download
D webkit/renderer/media/buffered_resource_loader.h View 1 chunk +0 lines, -331 lines 0 comments Download
D webkit/renderer/media/buffered_resource_loader.cc View 1 chunk +0 lines, -803 lines 0 comments Download
D webkit/renderer/media/buffered_resource_loader_unittest.cc View 1 chunk +0 lines, -1131 lines 0 comments Download
D webkit/renderer/media/cache_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/renderer/media/cache_util.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D webkit/renderer/media/cache_util_unittest.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D webkit/renderer/media/media_stream_audio_renderer.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/renderer/media/media_stream_audio_renderer.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D webkit/renderer/media/media_stream_client.h View 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/renderer/media/preload.h View 1 chunk +0 lines, -25 lines 0 comments Download
D webkit/renderer/media/test_response_generator.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/renderer/media/test_response_generator.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D webkit/renderer/media/texttrack_impl.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/renderer/media/texttrack_impl.cc View 1 1 chunk +0 lines, -37 lines 0 comments Download
D webkit/renderer/media/video_frame_provider.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/renderer/media/video_frame_provider.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/renderer/media/webaudiosourceprovider_impl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webkit/renderer/media/webaudiosourceprovider_impl.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D webkit/renderer/media/webaudiosourceprovider_impl_unittest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D webkit/renderer/media/webinbandtexttrack_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/renderer/media/webinbandtexttrack_impl.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M webkit/renderer/media/webkit_media.gypi View 2 chunks +0 lines, -45 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_delegate.h View 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_impl.h View 1 chunk +0 lines, -377 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_impl.cc View 1 1 chunk +0 lines, -1244 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -192 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_ms.cc View 1 chunk +0 lines, -443 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_params.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_params.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/renderer/media/webmediaplayer_util.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D webkit/renderer/media/webmediasourceclient_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/renderer/media/webmediasourceclient_impl.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/renderer/media/websourcebuffer_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/renderer/media/websourcebuffer_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
scherkus (not reviewing)
jam: please take a look The final(ish) piece to the puzzle... it's now more-or-less a ...
7 years, 5 months ago (2013-07-08 22:33:18 UTC) #1
jam
lgtm https://codereview.chromium.org/18261007/diff/6001/content/content_renderer.gypi File content/content_renderer.gypi (right): https://codereview.chromium.org/18261007/diff/6001/content/content_renderer.gypi#newcode437 content/content_renderer.gypi:437: 'renderer/media/audio_decoder.h', nit: just list the cc files in ...
7 years, 5 months ago (2013-07-09 01:17:49 UTC) #2
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/18261007/diff/6001/content/content_renderer.gypi File content/content_renderer.gypi (right): https://chromiumcodereview.appspot.com/18261007/diff/6001/content/content_renderer.gypi#newcode437 content/content_renderer.gypi:437: 'renderer/media/audio_decoder.h', On 2013/07/09 01:17:49, jam wrote: > nit: just ...
7 years, 5 months ago (2013-07-10 05:08:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18261007/33001
7 years, 5 months ago (2013-07-10 05:09:01 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-10 05:40:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18261007/51001
7 years, 5 months ago (2013-07-10 05:59:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=90792
7 years, 5 months ago (2013-07-10 07:16:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18261007/68001
7 years, 5 months ago (2013-07-10 15:13:27 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=90896
7 years, 5 months ago (2013-07-10 15:56:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18261007/3102
7 years, 5 months ago (2013-07-10 18:32:00 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-10 18:38:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18261007/3102
7 years, 5 months ago (2013-07-10 19:10:10 UTC) #12
scherkus (not reviewing)
7 years, 5 months ago (2013-07-10 19:37:27 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 manually as r210912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698