Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1826073002: Remove dependency of Blimp on X11/Xlib.h header to avoid namespace polution (Closed)

Created:
4 years, 9 months ago by xyzzyz
Modified:
4 years, 9 months ago
Reviewers:
Wez
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of Blimp on X11/Xlib.h header to avoid namespace polution by #define-s Xlib.h has #define Status int which conflicts with Status class in protobuf BUG=597321 Committed: https://crrev.com/f4a91b9728184d060805126d604cb7c8733624ee Cr-Commit-Position: refs/heads/master@{#382989}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M blimp/client/app/linux/blimp_main.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xyzzyz
4 years, 9 months ago (2016-03-23 23:31:18 UTC) #1
xyzzyz
4 years, 9 months ago (2016-03-23 23:32:02 UTC) #3
Wez
lgtm https://codereview.chromium.org/1826073002/diff/1/blimp/client/app/linux/blimp_main.cc File blimp/client/app/linux/blimp_main.cc (right): https://codereview.chromium.org/1826073002/diff/1/blimp/client/app/linux/blimp_main.cc#newcode29 blimp/client/app/linux/blimp_main.cc:29: gfx::InitializeThreadedX11(); nit: CHECK(...) so that we'll crash here ...
4 years, 9 months ago (2016-03-23 23:33:21 UTC) #4
xyzzyz
On 2016/03/23 23:33:21, Wez wrote: > lgtm > > https://codereview.chromium.org/1826073002/diff/1/blimp/client/app/linux/blimp_main.cc > File blimp/client/app/linux/blimp_main.cc (right): > ...
4 years, 9 months ago (2016-03-23 23:49:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826073002/20001
4 years, 9 months ago (2016-03-23 23:50:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 00:32:15 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:38:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4a91b9728184d060805126d604cb7c8733624ee
Cr-Commit-Position: refs/heads/master@{#382989}

Powered by Google App Engine
This is Rietveld 408576698