third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 1826013002: Enable compositing for opaque scrolling content on low DPI screens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 1826013002: Enable compositing for opaque scrolling content on low DPI screens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index d51d98fbb28c8b9f99f516629eb9d6e339d30261..d6884a23ab414a489c0c58539b84f49b9beac2d6 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -33,9 +33,10 @@ void CompositingReasonFinder::updateTriggers()

}

-bool CompositingReasonFinder::hasOverflowScrollTrigger() const

+bool CompositingReasonFinder::hasOverflowScrollTrigger(const PaintLayer* layer) const

{

- return m_compositingTriggers & OverflowScrollTrigger;

+ return m_compositingTriggers & OverflowScrollTrigger

+ || !layer->layoutObject()->style()->visitedDependentColor(CSSPropertyBackgroundColor).hasAlpha();

chrishtr 2016/05/25 15:55:22 You'll also have to ensure that the scroller is po

}

bool CompositingReasonFinder::isMainFrame() const

@@ -143,7 +144,7 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons

CompositingReasons directReasons = CompositingReasonNone;

LayoutObject* layoutObject = layer->layoutObject();

- if (hasOverflowScrollTrigger()) {

+ if (hasOverflowScrollTrigger(layer)) {

if (layer->clipParent())

directReasons |= CompositingReasonOutOfFlowClipping;