Enable compositing for opaque scrolling content on low DPI screens

third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@gmail.com>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 1476 matching lines @@
 
 static bool layerNeedsCompositedScrolling(PaintLayerScrollableArea::LCDTextMode mode, const PaintLayer* layer)
 {
     if (!layer->scrollsOverflow())
         return false;
 
     Node* node = layer->enclosingNode();
     if (node && node->isElementNode() && (toElement(node)->compositorMutableProperties() & (CompositorMutableProperty::kScrollTop | CompositorMutableProperty::kScrollLeft)))
         return true;
 
-    if (mode == PaintLayerScrollableArea::ConsiderLCDText && !layer->compositor()->preferCompositingToLCDTextEnabled())
+    // TODO(schenney) The color test alone is inadequate. When https://codereview.chromium.org/2196583002 lands
+    // we should use PaintLayer::shouldPaintBackgroundOntoForeground() because we will not still get
+    // LCD text unless the conditions there are met. It also unifies logic for scrolling compositing
+    // decisions.
+    bool backgroundSupportsLCDText = RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled()
+        && !layer->layoutObject()->style()->visitedDependentColor(CSSPropertyBackgroundColor).hasAlpha();
+    if (mode == PaintLayerScrollableArea::ConsiderLCDText
+        && !layer->compositor()->preferCompositingToLCDTextEnabled()
+        && !backgroundSupportsLCDText)
         return false;
 
-    return !layer->size().isEmpty()
-        && !layer->hasDescendantWithClipPath()
-        && !layer->hasAncestorWithClipPath()
-        && !layer->layoutObject()->style()->hasBorderRadius();
+    // TODO(schenney) Tests fail if we do not also exclude layer->layoutObject()->isFloating() (asserts) and

[chrishtr, 2016/08/04 16:35:44]

isFloating should have been fixed by https://codereview.chromium.org/2191953002.
The other is fixed by
better blacklisting above. Maybe just remove this TODO?

[Stephen Chennney, 2016/08/04 17:35:25]

Yep. Forgot you fixed that.

+    // layer->layoutObject()->style()->hasBorderDecoration() (missing background behind dashed borders).
+    // Resolve these cases, or not, and update this check with the results.
+    return !(layer->size().isEmpty()
+        || layer->hasDescendantWithClipPath()
+        || layer->hasAncestorWithClipPath()
+        || layer->layoutObject()->style()->hasBorderRadius());
 }
 
 void PaintLayerScrollableArea::updateNeedsCompositedScrolling(LCDTextMode mode)
 {
     const bool needsCompositedScrolling = layerNeedsCompositedScrolling(mode, layer());
     if (static_cast<bool>(m_needsCompositedScrolling) != needsCompositedScrolling) {
         m_needsCompositedScrolling = needsCompositedScrolling;
         layer()->didUpdateNeedsCompositedScrolling();
     }
 }
@@ skipping 244 matching lines @@
 
 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAreas()
 {
     for (auto& scrollableArea : *s_needsClamp)
         scrollableArea->clampScrollPositionsAfterLayout();
     delete s_needsClamp;
     s_needsClamp = nullptr;
 }
 
 } // namespace blink